Conversation
wiedenm
approved these changes
Jun 18, 2019
Member
There was a problem hiding this comment.
lgtm 👍
I can't come up with reasonable additional tests, at the moment. Postponing the cleanup is also fine with me. (In general, quite some portions of the code base could require some formatting/cleanup - at least I always need to turn off my save actions/auto formatting when working on already existing files since they tend to change a lot of lines.)
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
Anytype, a type designed to be assignable to any other type. In practiceAnys will only ever occur when the user callsops.run()(since if they useops.findOp()or some helper variant they will be usingNils) andAnys should never be specifyed by the user. The purpose ofAnyis as a hack to allow non-reifiable type parameters (such as those ofOutOfBoundsFactory) to pass matching. In practice this is a safe behavior, since if type parameters are non-reifiable they will never throwClassCastExceptions. If the type parameters are reifiable then they can be reified using aTypeExtractor.TODO: