You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review RichOp / OpInstance / OpMetadata API classes #86
Maybe OpBuilder should have convenience methods like richFunction() and richComputer()? Or: it could return OP where <OP extends T & RichOp<T>>, so the caller can assign to either. Then you wouldn't have to manually cast to RichOp after calling e.g. .function() on a built op. Not sure how much pain that would solve versus introduce, though.
If we did this, we'd want to expose RichOp in the OpEnvironment. Do we even want to do that? The only problem is that RichOp<T> does not extend T (and <T, OP extends T & RichOp<T>> is illegal) so anyone who used that, and then wanted to call that Op, would not have the Op's functional method available. If we don't do that, we will have to cast the OpEnvironment returns to RichOp, and we will assume that all OpEnvironments return RichOps under the hood. I'm not sure we want to make that assumption.
changed the title [-]Consider adding `RichOp` accessors to `OpBuilder`[/-][+]Review `RichOp` / `OpInstance` / `OpMetadata` API classes[/+]on Sep 26, 2023
Activity
gselzer commentedon Jan 14, 2022
If we did this, we'd want to expose
RichOpin theOpEnvironment. Do we even want to do that? The only problem is thatRichOp<T>does not extendT(and<T, OP extends T & RichOp<T>>is illegal) so anyone who used that, and then wanted to call that Op, would not have the Op's functional method available. If we don't do that, we will have to cast theOpEnvironmentreturns toRichOp, and we will assume that allOpEnvironments returnRichOps under the hood. I'm not sure we want to make that assumption.gselzer commentedon Sep 26, 2023
Plan of action:
OpMetadataclass entirely.RichOp) intoOpInstance?[-]Consider adding `RichOp` accessors to `OpBuilder`[/-][+]Review `RichOp` / `OpInstance` / `OpMetadata` API classes[/+]gselzer commentedon Oct 10, 2023
Closed with the merge of scijava/incubator#90