Skip to content

Review RichOp / OpInstance / OpMetadata API classes #86

Closed

Description

@ctrueden

Maybe OpBuilder should have convenience methods like richFunction() and richComputer()? Or: it could return OP where <OP extends T & RichOp<T>>, so the caller can assign to either. Then you wouldn't have to manually cast to RichOp after calling e.g. .function() on a built op. Not sure how much pain that would solve versus introduce, though.

Activity

  1. gselzer commented on Jan 14, 2022

    @gselzer
    Member

    If we did this, we'd want to expose RichOp in the OpEnvironment. Do we even want to do that? The only problem is that RichOp<T> does not extend T (and <T, OP extends T & RichOp<T>> is illegal) so anyone who used that, and then wanted to call that Op, would not have the Op's functional method available. If we don't do that, we will have to cast the OpEnvironment returns to RichOp, and we will assume that all OpEnvironments return RichOps under the hood. I'm not sure we want to make that assumption.

  2. gselzer commented on Sep 26, 2023

    @gselzer
    Member

    Plan of action:

    • Figure out whether we can just remove the OpMetadata class entirely.
    • If not, can we just merge it (and also maybe RichOp) into OpInstance?
  3. changed the title [-]Consider adding `RichOp` accessors to `OpBuilder`[/-] [+]Review `RichOp` / `OpInstance` / `OpMetadata` API classes[/+] on Sep 26, 2023
  4. gselzer commented on Oct 10, 2023

    @gselzer
    Member

    Closed with the merge of scijava/incubator#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions