Skip to content

ProvenanceTest: assert that matched ops actually match #83

Closed
scijava/incubator
#56

Description

Activity

  1. gselzer commented on Jan 21, 2022

    @gselzer
    Member

    The problem here is that these Ops will actually not be identical, as currently written.

    DefaultOpEnvironment.opFromInfoChain creates a new Op every time. This is because the opCache is keyed on MatchingConditions (the combined OpRef and Hints); we have neither of these when we want to call this method. For that reason, in the majority of cases the two Ops created will not be the same. We could ensure that they are from the same Class, I suppose...

  2. gselzer commented on Jan 21, 2022

    @gselzer
    Member

    In the case of test you commented on, that Op is a Function adapted from a Computers.Arity1, so it would take reflection to check equality beyond the wrapper (which is still worth testing, I think)

  3. added a commit that references this issue on May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions