Skip to content

Cleanly separate core ops infrastructure from ops discovery #59

Closed

Description

@ctrueden

For ops discovery, we want to use an industry standard mechanism (or mechanisms). Maybe Spring (#55), maybe plain ServiceLoader via JPMS module-info.java, maybe even something else. The Ops design should not conflate this with the engine itself, which has only the OpEnvironment interface, and accessor(s) for the OpInfos it has in its bag. Similarly, OpService as built on the SciJava service framework is a separate thing, which should not be part of the core ops engine at all.

To ensure this, the scijava-ops-api and scijava-ops-engine modules (or whatever they end up being named) must not depend on scijava-indexer, scijava-plugin, scijava-context, and similar layers relating to discovery, dependency injection, or application containers. It must be possible to create a "vanilla" OpEnvironment with a explicitly specified bag of ops.

Activity

  1. added this to the 1.0.0 milestone on Apr 29, 2021
  2. gselzer commented on May 13, 2021

    @gselzer
    Member

    Time commitment: 1 week

    (NB it could take substantially longer depending on which/how many modules we want to partition, but I think this is unlikely)

  3. self-assigned this
    on Nov 11, 2021
  4. gselzer commented on Jan 21, 2022

    @gselzer
    Member

    This has been completed. I can't determine which commit did it, but it was definitely done by the time we merged scijava/incubator#41

  5. gselzer commented on Jan 21, 2022

    @gselzer
    Member

    While we have not yet adopted Spring, Classgraph, or any other industry-standard discovery mechanism, any/all of them should be easily integrated through the Discoverer abstraction.

  6. added a commit that references this issue on May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions