Skip to content

Add validation for unnamed ops #162

Closed

Description

@hinerm

So, we have a weird situation where we have a validate method that is used to check OpInfos after they're made... but we also have OpImplData that is doing parsing but not doing any validation.

Why do we check e.g. single outputs in Infos instead of when parsing the OpImplData?

I want to add a check for unnamed Ops. It seems like OpImplData would be a reasonable place for this because, as indicated, there must be at least one name - but this is never checked anywhere.

Basically, if we want to do runtime checking for Op validity, we use the system as-is. If we want to do compile-time checking instead, we would migrate the InvalidOpExceptions to scijava-ops-indexer

Either way we can then add a check for Unnamed ops

Activity

  1. added this to the 1.0.0 milestone on Nov 29, 2023
  2. self-assigned this
    on Nov 29, 2023
  3. hinerm commented on Nov 29, 2023

    @hinerm
    MemberAuthor

    @gselzer @ctrueden I am partial for compile-time validation instead of runtime. How do you feel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions