Skip to content

Op dependency injection does not work for transformed ops #16

@wiedenm

Description

@wiedenm

@OpDependency-annotated fields of Ops that were transformed by some OpTransformer, and are therefore usually wrapped in some adapter, are not being populated during matching at the moment. The relevant method is OpService#resolveOpDependencies(Object) where only the outermost "layer" of the transformation hierarchy is inspected for dependencies.

See this gist to reproduce. The bug is reproducible on both master and migrate-imagej-ops, which is currently the main development branch.

This issue will likely be resolved by the ongoing efforts on branch op-methods where dependencies are resolved prior to the construction of an Op. So there should be no need to adjust resolveOpDependencies such that it considers the entire transformation chain. We should, however, make sure to add tests to cover this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions