Skip to content

No warning when using the wrong character for declaring op names #156

Closed

Description

@hinerm

When mistakenly using the ` character instead of ' to declare op names, I didn't receive any kind of warning that my op was not being indexed. It would be nice to know if an op exists but is essentially unreachable due to not having an op name.

image

Activity

  1. added this to the 1.0.0 milestone on Nov 16, 2023
  2. gselzer commented on Nov 16, 2023

    @gselzer
    Member

    Another option is to make that just work - we'd probably just have to edit the regex (I think it's here)

  3. self-assigned this
    on Nov 16, 2023
  4. hinerm commented on Nov 16, 2023

    @hinerm
    MemberAuthor

    Another option is to make that just work - we'd probably just have to edit the regex (I think it's here)

    I like this idea.. whenever you get to work on this, double-check what happens if you do names= with no value?

  5. assigned and unassigned on Nov 27, 2023
  6. hinerm commented on Nov 29, 2023

    @hinerm
    MemberAuthor

    Another option is to make that just work - we'd probably just have to edit the regex (I think it's here)

    @gselzer I don't see any actual uses of the indexer:
    image

    How is it being used..?

  7. hinerm commented on Nov 29, 2023

    @hinerm
    MemberAuthor

    How is it being used..?

    OK.. I just had to rebuild the project multiple times for changes to take effect.

  8. ctrueden commented on Nov 29, 2023

    @ctrueden
    Member

    Ahh, this reminds me: we were originally going to have scijava-ops-indexer its own repository and separately published project, so that the multi-module Maven project using it at build time would not have this "non-Maven-way" code smell.

    But if scijava-indexer is going to depend on scijava-ops-api now, we would also need scijava-ops-api and all its dependencies to be a separate repo as well? Tricky.....

  9. added 2 commits that reference this issue on May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions