Skip to content

Commit fe8c0c5

Browse files
ctruedenclaude
authored andcommitted
Fix generated class names for nested array types
Reduced and converted op wrappers derive a class name from the parameter types, replacing "[]" with "_Arr". This was done only one level deep, so a parameter such as double[][] produced an invalid class name and the op could not be called with its optional parameters omitted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent d278c9f commit fe8c0c5

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/Conversions.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ static String getClassName(Type t) {
479479
var className = clazz.getSimpleName();
480480
if (className.chars().allMatch(Character::isJavaIdentifierPart))
481481
return className;
482-
if (clazz.isArray()) return clazz.getComponentType().getSimpleName() +
482+
if (clazz.isArray()) return getClassName(clazz.getComponentType()) +
483483
"_Arr";
484484
return className;
485485
}

‎scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/reduce/ReductionUtils.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ private static String getClassName(Class<?> clazz) {
176176
var className = clazz.getSimpleName();
177177
if (className.chars().allMatch(c -> Character.isJavaIdentifierPart(c)))
178178
return className;
179-
if (clazz.isArray()) return clazz.getComponentType().getSimpleName() +
179+
if (clazz.isArray()) return getClassName(clazz.getComponentType()) +
180180
"_Arr";
181181
return className;
182182
}

0 commit comments

Comments
 (0)