Fix javassist class names for converted Ops

gselzer · gselzer · commit e87ffe6b1fa8 · 2024-03-19T16:45:11.000-05:00
diff --git a/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/Conversions.java b/scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/Conversions.java
@@ -579,13 +579,8 @@ private static String formClassName(OpInfo altered) {
 		StringBuilder sb = new StringBuilder(packageName + ".");
 
 		// class name
-		// FIXME: This procedure, while generally safe, has a bug for method Ops,
-		// where the implementationName return contains parameter types. If those
-		// parameters are described by FQCN, they may contain periods, which will
-		// affect the expected stopping point.
 		String implementationName = altered.implementationName();
-		String className = implementationName.replaceAll("[^a-zA-Z0-9.\\-]", "_");
-		className = className.substring(className.lastIndexOf(".") + 1);
+		String className = implementationName.replaceAll("[^a-zA-Z0-9\\-]", "_");
 		if (className.chars().anyMatch(c -> !Character.isJavaIdentifierPart(c)))
 			throw new IllegalArgumentException(className +
 				" is not a valid class name!");
