Skip to content

Commit dfc8cf1

Browse files
committed
Member: Remove 'get' from getter methods
1 parent 7c67416 commit dfc8cf1

30 files changed

+73
-80
lines changed

scijava-ops-api/src/main/java/org/scijava/ops/api/OpInfo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ default List<Member<?>> inputs() {
7575
/** Gets the types of the op's input parameters. */
7676
default List<Type> inputTypes() {
7777
return inputs().stream() //
78-
.map(Member::getType) //
78+
.map(Member::type) //
7979
.collect(Collectors.toList());
8080
}
8181

@@ -98,7 +98,7 @@ default Member<?> output() {
9898

9999
/** Gets the op's output parameter, if there is <b>exactly</b> one. */
100100
default Type outputType() {
101-
return output().getType();
101+
return output().type();
102102
}
103103

104104
/** The op's priority. */

scijava-ops-engine/src/main/java/org/scijava/ops/engine/impl/DefaultOpDescriptionGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ else if (m.getIOType() == CONTAINER) {
195195
sb.append("@CONTAINER ");
196196
}
197197
// describe member type
198-
sb.append(describeType(env, Nil.of(m.getType())));
198+
sb.append(describeType(env, Nil.of(m.type())));
199199
if (!m.isRequired()) {
200200
sb.append(" = null");
201201
}
@@ -212,7 +212,7 @@ else if (m.getIOType() == CONTAINER) {
212212
sb.append("None");
213213
}
214214
else {
215-
sb.append(describeType(env, Nil.of(output.getType())));
215+
sb.append(describeType(env, Nil.of(output.type())));
216216
}
217217
// return concatenation
218218
return sb.toString();

scijava-ops-engine/src/main/java/org/scijava/ops/engine/impl/DefaultOpEnvironment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ private List<RichOp<?>> resolveOpDependencies(OpInfo info,
663663
}
664664
catch (final OpMatchingException e) {
665665
String message = DependencyMatchingException.message(info
666-
.implementationName(), dependency.getKey(), request);
666+
.implementationName(), dependency.key(), request);
667667
if (e instanceof DependencyMatchingException) {
668668
throw new DependencyMatchingException(message,
669669
(DependencyMatchingException) e);
@@ -678,7 +678,7 @@ private OpRequest inferOpRequest(OpDependencyMember<?> dependency,
678678
Map<TypeVariable<?>, Type> typeVarAssigns)
679679
{
680680
final Type mappedDependencyType = Types.mapVarToTypes(new Type[] {
681-
dependency.getType() }, typeVarAssigns)[0];
681+
dependency.type() }, typeVarAssigns)[0];
682682
final String dependencyName = dependency.getDependencyName();
683683
return inferOpRequest(mappedDependencyType, dependencyName, typeVarAssigns);
684684
}

scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/adapt/AdaptationInfoTreeGenerator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ public InfoTree generate(OpEnvironment env, String signature,
7777
// TODO: The op type is wrong!
7878
Map<TypeVariable<?>, Type> typeVarAssigns = new HashMap<>();
7979
if (!Types.isAssignable(originalInfo.opType(), adaptorTree.info().inputs()
80-
.get(0).getType(), typeVarAssigns)) throw new IllegalArgumentException(
80+
.get(0).type(), typeVarAssigns)) throw new IllegalArgumentException(
8181
"The adaptor cannot be used on Op " + originalInfo);
8282
Type adaptedOpType = Types.substituteTypeVariables(adaptorTree.info()
83-
.output().getType(), typeVarAssigns);
83+
.output().type(), typeVarAssigns);
8484
OpInfo adaptedInfo = new OpAdaptationInfo(originalInfo, adaptedOpType,
8585
adaptorTree);
8686
return new InfoTree(adaptedInfo, originalTree.dependencies());

scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/adapt/AdaptationMatchingRoutine.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public OpCandidate findMatch(MatchingConditions conditions, OpMatcher matcher,
104104
List<Exception> matchingExceptions = new ArrayList<>();
105105
List<DependencyMatchingException> depExceptions = new ArrayList<>();
106106
for (final OpInfo adaptor : env.infos("engine.adapt")) {
107-
Type adaptTo = adaptor.output().getType();
107+
Type adaptTo = adaptor.output().type();
108108
Map<TypeVariable<?>, Type> map = new HashMap<>();
109109
// make sure that the adaptor outputs the correct type
110110
if (!adaptOpOutputSatisfiesReqTypes(adaptTo, map, conditions.request()))
@@ -145,7 +145,7 @@ public OpCandidate findMatch(MatchingConditions conditions, OpMatcher matcher,
145145
}).collect(Collectors.toList());
146146
// And return the Adaptor, wrapped up into an OpCandidate
147147
Type adapterOpType = Types.substituteTypeVariables(adaptor.output()
148-
.getType(), map);
148+
.type(), map);
149149
InfoTree adaptorChain = new InfoTree(adaptor, depTrees);
150150
OpAdaptationInfo adaptedInfo = new OpAdaptationInfo(srcCandidate
151151
.opInfo(), adapterOpType, adaptorChain);
@@ -206,14 +206,14 @@ private OpRequest inferOpRequest(OpDependencyMember<?> dependency,
206206
Map<TypeVariable<?>, Type> typeVarAssigns)
207207
{
208208
final Type mappedDependencyType = Types.mapVarToTypes(new Type[] {
209-
dependency.getType() }, typeVarAssigns)[0];
209+
dependency.type() }, typeVarAssigns)[0];
210210
final String dependencyName = dependency.getDependencyName();
211211
final OpRequest inferred = inferOpRequest(mappedDependencyType,
212212
dependencyName, typeVarAssigns);
213213
if (inferred != null) return inferred;
214214
throw new OpMatchingException("Could not infer functional " +
215215
"method inputs and outputs of Op dependency field: " + dependency
216-
.getKey());
216+
.key());
217217
}
218218

219219
private boolean adaptOpOutputSatisfiesReqTypes(Type adaptTo,

scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/convert/ConvertedOpInfo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ public String implementationName() {
225225
for (Member<?> m : struct()) {
226226
if (m.isInput() || m.isOutput()) {
227227
sb.append("_");
228-
sb.append(Conversions.getClassName(m.getType()));
228+
sb.append(Conversions.getClassName(m.type()));
229229
}
230230
}
231231
return sb.toString();

scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/impl/DefaultOpClassInfo.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,10 @@ public StructInstance<?> createOpInstance(List<?> dependencies) {
158158
// dependency.
159159
throw new IllegalStateException(
160160
"Exception trying to inject Op dependency field.\n" +
161-
"\tOp dependency field to resolve: " + dependencyMember.getKey() +
161+
"\tOp dependency field to resolve: " + dependencyMember.key() +
162162
"\n" + "\tFound Op to inject: " + dependencies.get(i).getClass()
163163
.getName() + //
164-
"\n" + "\tField signature: " + dependencyMember.getType(), ex);
164+
"\n" + "\tField signature: " + dependencyMember.type(), ex);
165165
}
166166
}
167167
return struct().createInstance(op);

scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/impl/InfoMatchingOpRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public InfoMatchingOpRequest(OpInfo info, Nil<?> specialType) {
7575
if (!Types.isAssignable(from, this.type, this.map))
7676
throw new IllegalArgumentException();
7777
}
78-
args = info.inputs().stream().map(m -> mappedType(m.getType(), this.map))
78+
args = info.inputs().stream().map(m -> mappedType(m.type(), this.map))
7979
.toArray(Type[]::new);
8080
outType = mappedType(info.outputType(), this.map);
8181
}

scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/impl/RuntimeSafeMatchingRoutine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ private boolean inputsMatch(final OpCandidate candidate,
198198
Type[] implTypeParams = ((ParameterizedType) implementedInfoType)
199199
.getActualTypeArguments();
200200
Type[] candidateArgTypes = candidate.opInfo().struct().members().stream()//
201-
.map(member -> member.isInput() ? member.getType() : null) //
201+
.map(member -> member.isInput() ? member.type() : null) //
202202
.toArray(Type[]::new);
203203
for (int i = 0; i < implTypeParams.length; i++) {
204204
if (candidateArgTypes[i] == null) implTypeParams[i] = null;

scijava-ops-engine/src/main/java/org/scijava/ops/engine/matcher/reduce/AbstractInfoReducer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public ReducedOpInfo reduce(OpInfo info, int numReductions) {
5454
int reducedArity = originalArity - numReductions;
5555
Class<?> reducedRawType = ofArity(reducedArity);
5656
Type[] inputTypes = info.inputTypes().toArray(Type[]::new);
57-
Type outputType = info.output().getType();
57+
Type outputType = info.output().type();
5858
Type[] newTypes = new Type[reducedArity + 1];
5959
if (reducedArity >= 0) System.arraycopy(inputTypes, 0, newTypes, 0,
6060
reducedArity);

0 commit comments

Comments
 (0)