Merge pull request #105 from scijava/scijava/scijava-ops-engine/remove-description-nulls

gselzer · web-flow · commit dea0406b5e69 · 2023-12-20T13:49:45.000-06:00
Remove null names in Op descriptions
diff --git a/scijava/scijava-ops-engine/src/main/java/org/scijava/ops/engine/yaml/AbstractYAMLOpInfoCreator.java b/scijava/scijava-ops-engine/src/main/java/org/scijava/ops/engine/yaml/AbstractYAMLOpInfoCreator.java
@@ -147,7 +147,10 @@ else if (p instanceof String) {
     private Member<?> wrapMember(final Member<?> member, final Map<String, Object> map) {
         String name = member.getKey();
         if (member.isInput() && !member.isOutput()) {
-            name = (String) map.get("INPUT");
+            var newName = (String) map.get("name");
+            if (newName != null) {
+                name = newName;
+            }
         }
         else {
             for (String key: outputKeys) {
diff --git a/scijava/scijava-ops-engine/src/test/java/org/scijava/ops/engine/yaml/impl/YAMLOpTest.java b/scijava/scijava-ops-engine/src/test/java/org/scijava/ops/engine/yaml/impl/YAMLOpTest.java
@@ -99,4 +99,17 @@ public void testYAMLField() {
 		Assertions.assertEquals(6., sum, 1e-6);
 	}
 
+	@Test
+	public void testYAMLDescription() {
+		var actual = ops.help("example.mul");
+		var expected = "Ops:\n\t> example.mul(" + //
+				"\n\t\t Inputs:" +  //
+				"\n\t\t\tDouble a -> the first double" + //
+				"\n\t\t\tDouble b -> the first double" + //
+				"\n\t\t Outputs:" + //
+				"\n\t\t\tDouble output1 -> the product" + //
+				"\n\t)\n\t";
+		Assertions.assertEquals(expected, actual);
+	}
+
 }
