Skip to content

Commit dd628b5

Browse files
committed
scijava-ops-image: rewrite open module comment
It's not a hack, exactly. Individually opening every one of the 105 org.scijava.ops.image.** packages is very verbose, and also does not fully work on its own to let all tests pass. Maybe there are also scijava.surefire.args flags that need to be set? But rather than mess with that, we stick with the solution that works via a single keyword.
1 parent f374471 commit dd628b5

File tree

1 file changed

+2
-12
lines changed

1 file changed

+2
-12
lines changed

scijava-ops-image/src/main/java/module-info.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,8 @@
2727
* #L%
2828
*/
2929

30-
// HACK: Open the scijava-ops-image module completely.
31-
//
32-
// What's supposed to be needed is:
33-
// opens org.scijava.ops.tutorial to org.scijava.ops.engine;
34-
//
35-
// Unfortunately, doing that results in the following error at test time:
36-
//
37-
// Error occurred during initialization of boot layer
38-
// java.lang.module.FindException: Error reading module:
39-
// .../scijava/scijava-ops-image/target/classes
40-
//
41-
// Whereas fully opening the module works for some reason.
30+
// This module is open so that scijava-ops-engine can access
31+
// all of its many Op implementations via reflection.
4232
open module org.scijava.ops.image {
4333

4434
requires java.scripting;

0 commit comments

Comments
 (0)