Types.isAssignable: only assign non-Any types

hinerm · hinerm · commit db972f0a574b · 2024-04-01T11:17:43.000-05:00
isAssignable has a side effect of assigning type variables. However, we do not want to assign Any's or this will break adaptation. Fix provided by @gselzer
diff --git a/scijava-types/src/main/java/org/scijava/types/Types.java b/scijava-types/src/main/java/org/scijava/types/Types.java
@@ -2345,7 +2345,9 @@ private static boolean isAssignable(final Type type,
 				for (final Type bound : toTypeVarBounds) {
 					if (!isAssignable(type, bound, typeVarAssigns)) return false;
 				}
-				typeVarAssigns.put(toTypeVariable, type);
+				if (!Any.is(type)) {
+					typeVarAssigns.put(toTypeVariable, type);
+				}
 
 				return true;
 			}

Original file line number	Diff line number	Diff line change
`@@ -2345,7 +2345,9 @@ private static boolean isAssignable(final Type type,`
`2345`	`2345`	`for (final Type bound : toTypeVarBounds) {`
`2346`	`2346`	`if (!isAssignable(type, bound, typeVarAssigns)) return false;`
`2347`	`2347`	`}`
`2348`		`- typeVarAssigns.put(toTypeVariable, type);`
	`2348`	`+ if (!Any.is(type)) {`
	`2349`	`+ typeVarAssigns.put(toTypeVariable, type);`
	`2350`	`+ }`
`2349`	`2351`
`2350`	`2352`	`return true;`
`2351`	`2353`	`}`