Avoid duplicate types in TypeVarInfo

Treiblesschorle · ctrueden · commit d95f2e201ea5 · 2019-04-18T12:16:30.000-05:00
diff --git a/src/main/java/org/scijava/util/Types.java b/src/main/java/org/scijava/util/Types.java
@@ -1302,12 +1302,12 @@ private static class TypeVarInfo {
 
 		private final TypeVariable<?> var;
 		private final Type[] upperBounds;
-		private List<Type> types;
+		private Set<Type> types;
 
 		public TypeVarInfo(final TypeVariable<?> var) {
 			this.var = var;
 			this.upperBounds = var.getBounds();
-			this.types = new ArrayList<>();
+			this.types = new HashSet<>();
 		}
 
 		/**
@@ -1351,13 +1351,12 @@ public boolean fixBounds(final Type bound) {
 
 			// make sure that all of the types that already fit in this variable
 			// before the variable was fixed still are allowed by the type variable.
-			final List<Type> temp = types;
+			final Set<Type> temp = types;
 			temp.add(bound);
-			types = new ArrayList<>();
+			types = new HashSet<>();
 			for (final Type type : temp) {
 				if (!allowType(type)) return false;
 			}
-
 			return true;
 		}
 		
