Skip to content

Commit c4de1c0

Browse files
committed
Fix the benchmarks generation to work again
1 parent 3b3f3b2 commit c4de1c0

File tree

5 files changed

+17
-6
lines changed

5 files changed

+17
-6
lines changed

docs/ops/bin/benchmark.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ fi
1111

1212
SCRIPT_PATH=$(dirname "$(realpath -s "$0")")
1313
DOCS_OPS_PATH="$SCRIPT_PATH/.."
14-
INC_PATH="$DOCS_OPS_PATH/../../"
15-
BENCHMARKS_PATH="$INC_PATH/scijava-ops-benchmarks"
14+
BASE_PATH="$DOCS_OPS_PATH/../../"
15+
BENCHMARKS_PATH="$BASE_PATH/scijava-ops-benchmarks"
1616
BENCH_OUT_FILE=scijava-ops-benchmarks_results.json
1717
BENCH_OUT_PATH=$(realpath -s "$DOCS_OPS_PATH/$BENCH_OUT_FILE")
1818

@@ -24,8 +24,8 @@ then
2424
else
2525
echo
2626
echo '=== BUILDING THE CODE ==='
27-
cd "$INC_PATH"
28-
mvn -Denforcer.skip -Dinvoker.skip -Dmaven.test.skip -P benchmarks clean install -pl scijava-ops-benchmarks -am | grep '\(Building.*[0-9]\]\|ERROR\)'
27+
cd "$BASE_PATH"
28+
mvn -Denforcer.skip -Dinvoker.skip -Dmaven.test.skip -P benchmarks clean install -pl scijava-ops-benchmarks -am
2929

3030
echo
3131
echo '=== COPYING DEPENDENCIES ==='

docs/ops/doc/Benchmarks.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ Reproducing these Results
119119
1. Create a local copy of the SciJava core from the `GitHub repository <https://github.com/scijava/scijava>`_
120120
2. Ensure you have package manager `Mamba <https://mamba.readthedocs.io/en/latest/installation/mamba-installation.html#fresh-install-recommended>`_ installed.
121121
3. Run the script `docs/ops/bin/benchmark.sh`, which will:
122-
* Create the mamba Environment
122+
* Create the mamba environment
123123
* Build the benchmarking code
124124
* Execute all JMH benchmarks
125125
* Build `plotly <https://plotly.com/>`_ figures for each benchmark

docs/ops/environment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ dependencies:
66
- myst-nb
77
- openjdk=11
88
- plotly
9-
- sphinx
9+
- sphinx=7.2
1010
- sphinx-copybutton
1111
- sphinx_rtd_theme
1212

pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,4 +102,13 @@
102102
<maven.deploy.skip>true</maven.deploy.skip>
103103
<maven.install.skip>true</maven.install.skip>
104104
</properties>
105+
106+
<profiles>
107+
<profile>
108+
<id>benchmarks</id>
109+
<modules>
110+
<module>scijava-ops-benchmarks</module>
111+
</modules>
112+
</profile>
113+
</profiles>
105114
</project>

scijava-ops-benchmarks/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,5 +338,7 @@
338338
</pluginManagement>
339339
</build>
340340
</profile>
341+
<!-- HACK: Squelch profile activation warning. -->
342+
<profile><id>benchmarks</id></profile>
341343
</profiles>
342344
</project>

0 commit comments

Comments
 (0)