You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 66b1b20
Browse filesBrowse the repository at this point in the historyBrowse files
scijava-execute: run things that declare their inputs and outputs
Phase 3 begins. @parameter on fields, a MemberParser that reads them
(inherited ones included), and Executables.run, which binds inputs by
name and hands back outputs by name -- SciJava Common's module layer,
rebuilt on scijava-struct.
@parameter here means only what it meant in SciJava Common's module
sense: an input or output of something runnable. Injecting a service is
@dependency, in scijava-context. Conflating the two is what made the
original annotation confusing.
Cancellation needed nothing of its own, as the design predicted: a run is
a Callable for an executor, and cancelling the Future interrupts it. The
test cancels a sleeping task and checks it did not reach the end.
Two bugs the tests caught:
- FieldParameterMember inherited Member's read-only createInstance, so
every input binding threw UnsupportedOperationException. It must return
a ValueAccessibleMemberInstance to be writable.
- The required-input check tested whether the field was null, which
silently passes for primitives: a missing required double would have
run as 0.0 and produced a wrong answer rather than an error. A required
input must now be supplied, not merely non-null.
On lifting the member parsers out of ops-engine, which the plan called
for: inspecting ops.engine.struct, only about five of nineteen classes
are framework-neutral. The parsers reach into Op-specific exceptions,
Op-specific annotations (@nullable and @OpDependency, in the already
released scijava-ops-spi) and ops.engine.util helpers, so lifting them
means first deciding where an optional-parameter annotation lives and
then changing a released module. Better to build this layer first and let
a second real consumer show what is genuinely shared. The plan records
the specific couplings.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013gJpzGd3ksbME4CN6Tu2ni
0 commit comments