Skip to content

Commit 4b8feff

Browse files
ctruedenclaude
andcommitted
Pin every consumed SciJava artifact version
Six components resolved released 1.0.0 artifacts instead of the reactor's snapshots, because these modules inherit from pom-scijava rather than this repository's aggregator POM: an absent version property does not fail, it silently falls back to the last released version in pom-scijava's dependency management. scijava-legacy, for instance, pulled released scijava-meta and scijava-struct 1.0.0, whose classes reference org.scijava.common3 interfaces. That only surfaces when an API changes, as a NoClassDefFoundError far from its cause. Also defines scijava-priority.version in scijava-discovery, which referenced the property without declaring it. Audited with dependency:list against the reactor versions; zero mismatches remain. Nothing enforces this convention -- an enforcer rule would be worth adding. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gJpzGd3ksbME4CN6Tu2ni
1 parent 0771222 commit 4b8feff

9 files changed

Lines changed: 26 additions & 83 deletions

File tree

‎scijava-common3/src/main/java/org/scijava/common3/GenericTyped.java‎

Lines changed: 0 additions & 42 deletions
This file was deleted.

‎scijava-common3/src/main/java/org/scijava/common3/Versioned.java‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

‎scijava-discovery-test/pom.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@
9292
<!-- Note: These versions must match across all component POMs! -->
9393
<scijava-discovery.version>1.0.1-SNAPSHOT</scijava-discovery.version>
9494
<scijava-ops-spi.version>1.0.1-SNAPSHOT</scijava-ops-spi.version>
95+
<scijava-priority.version>1.0.1-SNAPSHOT</scijava-priority.version>
9596
</properties>
9697

9798
<dependencies>

‎scijava-discovery/pom.xml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@
8484

8585
<license.licenseName>bsd_2</license.licenseName>
8686
<license.copyrightOwners>SciJava developers.</license.copyrightOwners>
87+
88+
<!-- Note: These versions must match across all component POMs! -->
89+
<scijava-priority.version>1.0.1-SNAPSHOT</scijava-priority.version>
8790
</properties>
8891

8992
<dependencies>

‎scijava-legacy/pom.xml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,17 @@
8585
<license.copyrightOwners>SciJava developers.</license.copyrightOwners>
8686

8787
<!-- Note: These versions must match across all component POMs! -->
88+
<scijava-collections.version>1.0.1-SNAPSHOT</scijava-collections.version>
8889
<scijava-common3.version>1.0.1-SNAPSHOT</scijava-common3.version>
8990
<scijava-discovery.version>1.0.1-SNAPSHOT</scijava-discovery.version>
91+
<scijava-function.version>1.0.1-SNAPSHOT</scijava-function.version>
92+
<scijava-meta.version>1.0.1-SNAPSHOT</scijava-meta.version>
9093
<scijava-ops-api.version>1.0.1-SNAPSHOT</scijava-ops-api.version>
9194
<scijava-ops-engine.version>1.0.1-SNAPSHOT</scijava-ops-engine.version>
9295
<scijava-ops-spi.version>1.0.1-SNAPSHOT</scijava-ops-spi.version>
9396
<scijava-priority.version>1.0.1-SNAPSHOT</scijava-priority.version>
9497
<scijava-progress.version>1.0.1-SNAPSHOT</scijava-progress.version>
98+
<scijava-struct.version>1.0.1-SNAPSHOT</scijava-struct.version>
9599
<scijava-types.version>1.0.1-SNAPSHOT</scijava-types.version>
96100
</properties>
97101

‎scijava-ops-flim/pom.xml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,20 @@
9696
<license.copyrightOwners>SciJava developers.</license.copyrightOwners>
9797

9898
<!-- Note: These versions must match across all component POMs! -->
99+
<scijava-collections.version>1.0.1-SNAPSHOT</scijava-collections.version>
100+
<scijava-common3.version>1.0.1-SNAPSHOT</scijava-common3.version>
99101
<scijava-concurrent.version>1.0.1-SNAPSHOT</scijava-concurrent.version>
100102
<scijava-discovery.version>1.0.1-SNAPSHOT</scijava-discovery.version>
101103
<scijava-function.version>1.0.1-SNAPSHOT</scijava-function.version>
104+
<scijava-meta.version>1.0.1-SNAPSHOT</scijava-meta.version>
102105
<scijava-ops-api.version>1.0.1-SNAPSHOT</scijava-ops-api.version>
103106
<scijava-ops-engine.version>1.0.1-SNAPSHOT</scijava-ops-engine.version>
104107
<scijava-ops-image.version>2.0.0-SNAPSHOT</scijava-ops-image.version>
105108
<scijava-ops-indexer.version>1.0.1-SNAPSHOT</scijava-ops-indexer.version>
106109
<scijava-ops-spi.version>1.0.1-SNAPSHOT</scijava-ops-spi.version>
107110
<scijava-priority.version>1.0.1-SNAPSHOT</scijava-priority.version>
111+
<scijava-progress.version>1.0.1-SNAPSHOT</scijava-progress.version>
112+
<scijava-struct.version>1.0.1-SNAPSHOT</scijava-struct.version>
108113
<scijava-taglets.version>1.0.1-SNAPSHOT</scijava-taglets.version>
109114
<scijava-types.version>1.0.1-SNAPSHOT</scijava-types.version>
110115

‎scijava-ops-image/pom.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -258,6 +258,7 @@
258258
<scijava-ops-spi.version>1.0.1-SNAPSHOT</scijava-ops-spi.version>
259259
<scijava-priority.version>1.0.1-SNAPSHOT</scijava-priority.version>
260260
<scijava-progress.version>1.0.1-SNAPSHOT</scijava-progress.version>
261+
<scijava-struct.version>1.0.1-SNAPSHOT</scijava-struct.version>
261262
<scijava-taglets.version>1.0.1-SNAPSHOT</scijava-taglets.version>
262263
<scijava-testutil.version>1.0.1-SNAPSHOT</scijava-testutil.version>
263264
<scijava-types.version>1.0.1-SNAPSHOT</scijava-types.version>

‎scijava-ops-opencv/pom.xml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,20 @@
100100
<scijava.surefire.args>--add-reads org.scijava.ops.opencv=org.scijava.ops.api,net.imglib2</scijava.surefire.args>
101101

102102
<!-- Note: These versions must match across all component POMs! -->
103+
<scijava-collections.version>1.0.1-SNAPSHOT</scijava-collections.version>
104+
<scijava-common3.version>1.0.1-SNAPSHOT</scijava-common3.version>
105+
<scijava-concurrent.version>1.0.1-SNAPSHOT</scijava-concurrent.version>
103106
<scijava-discovery.version>1.0.1-SNAPSHOT</scijava-discovery.version>
107+
<scijava-function.version>1.0.1-SNAPSHOT</scijava-function.version>
108+
<scijava-meta.version>1.0.1-SNAPSHOT</scijava-meta.version>
104109
<scijava-ops-api.version>1.0.1-SNAPSHOT</scijava-ops-api.version>
105110
<scijava-ops-engine.version>1.0.1-SNAPSHOT</scijava-ops-engine.version>
106111
<scijava-ops-image.version>2.0.0-SNAPSHOT</scijava-ops-image.version>
107112
<scijava-ops-indexer.version>1.0.1-SNAPSHOT</scijava-ops-indexer.version>
108113
<scijava-ops-spi.version>1.0.1-SNAPSHOT</scijava-ops-spi.version>
109114
<scijava-priority.version>1.0.1-SNAPSHOT</scijava-priority.version>
115+
<scijava-progress.version>1.0.1-SNAPSHOT</scijava-progress.version>
116+
<scijava-struct.version>1.0.1-SNAPSHOT</scijava-struct.version>
110117
<scijava-taglets.version>1.0.1-SNAPSHOT</scijava-taglets.version>
111118
<scijava-types.version>1.0.1-SNAPSHOT</scijava-types.version>
112119

‎scijava-ops-tutorial/pom.xml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,16 +100,21 @@
100100
<maven.install.skip>true</maven.install.skip>
101101

102102
<!-- Note: These versions must match across all component POMs! -->
103+
<scijava-collections.version>1.0.1-SNAPSHOT</scijava-collections.version>
104+
<scijava-common3.version>1.0.1-SNAPSHOT</scijava-common3.version>
105+
<scijava-concurrent.version>1.0.1-SNAPSHOT</scijava-concurrent.version>
103106
<scijava-discovery.version>1.0.1-SNAPSHOT</scijava-discovery.version>
104107
<scijava-function.version>1.0.1-SNAPSHOT</scijava-function.version>
105108
<scijava-indexer.version>1.0.1-SNAPSHOT</scijava-indexer.version>
109+
<scijava-meta.version>1.0.1-SNAPSHOT</scijava-meta.version>
106110
<scijava-ops-api.version>1.0.1-SNAPSHOT</scijava-ops-api.version>
107111
<scijava-ops-engine.version>1.0.1-SNAPSHOT</scijava-ops-engine.version>
108112
<scijava-ops-image.version>2.0.0-SNAPSHOT</scijava-ops-image.version>
109113
<scijava-ops-indexer.version>1.0.1-SNAPSHOT</scijava-ops-indexer.version>
110114
<scijava-ops-spi.version>1.0.1-SNAPSHOT</scijava-ops-spi.version>
111115
<scijava-priority.version>1.0.1-SNAPSHOT</scijava-priority.version>
112116
<scijava-progress.version>1.0.1-SNAPSHOT</scijava-progress.version>
117+
<scijava-struct.version>1.0.1-SNAPSHOT</scijava-struct.version>
113118
<scijava-taglets.version>1.0.1-SNAPSHOT</scijava-taglets.version>
114119
<scijava-types.version>1.0.1-SNAPSHOT</scijava-types.version>
115120

0 commit comments

Comments
 (0)