OpParser: support multiple aliases

hinerm · hinerm · commit 2d11d92b66b3 · 2024-03-06T08:45:43.000-06:00
diff --git a/scijava-ops-ext-parser/src/main/java/org/scijava/ops/parser/OpParser.java b/scijava-ops-ext-parser/src/main/java/org/scijava/ops/parser/OpParser.java
@@ -152,8 +152,16 @@ public static String parseOpDocument(String inputYamlPath)
 				final double priority = Double.parseDouble((String) opMetadata
 					.getOrDefault(PRIORITY_KEY, "0.0"));
 
-				opNames.add((String) opMetadata.getOrDefault(ALIAS_KEY, "ext" +
-					methodName));
+				if (opMetadata.containsKey(ALIAS_KEY)) {
+					Object alias = opMetadata.get(ALIAS_KEY);
+					if (alias instanceof String) {
+						opNames.add((String)alias);
+					} else if (alias instanceof List) {
+						opNames.addAll((List<String>)alias);
+					}
+				} else {
+					opNames.add("ext." + methodName);
+				}
 
 				List<String> opAuthors = authors;
 				if (opMetadata.containsKey(AUTHOR_KEY)) {
diff --git a/scijava-ops-ext-parser/src/test/java/org/scijava/ops/parser/TestOpParser.java b/scijava-ops-ext-parser/src/test/java/org/scijava/ops/parser/TestOpParser.java
@@ -49,7 +49,7 @@ public void validateParsing() throws ClassNotFoundException {
 
 		String expected = //
 			"- op:" //
-				+ "\n    names: [arrays.toStringDeep, test.deepToString]" //
+				+ "\n    names: [arrays.toStringDeep, fun.stringMaker, test.deepToString]" //
 				+ "\n    description: ''" //
 				+
 				"\n    source: javaMethod:/java.util.Arrays.deepToString%28%5BLjava.lang.Object%3B%29" //
@@ -61,7 +61,7 @@ public void validateParsing() throws ClassNotFoundException {
 				+ "\n    authors: [Nobody, Everybody]" //
 				+ "\n    tags: {}" //
 				+ "\n- op:" //
-				+ "\n    names: [system.arraycopy, test.arraycopy]" //
+				+ "\n    names: [ext.arraycopy, test.arraycopy]" //
 				+ "\n    description: a useful op" //
 				+
 				"\n    source: javaMethod:/java.lang.System.arraycopy%28java.lang.Object%2Cint%2Cjava.lang.Object%2Cint%2Cint%29" //
diff --git a/scijava-ops-ext-parser/src/test/resources/test-ops.yaml b/scijava-ops-ext-parser/src/test/resources/test-ops.yaml
@@ -6,11 +6,12 @@ authors:
 
 java.util.Arrays:
   deepToString:
-    alias: "arrays.toStringDeep"
+    alias:
+      - "arrays.toStringDeep"
+      - "fun.stringMaker"
 
 java.lang.System:
   arraycopy:
-    alias: "system.arraycopy"
     priority: "50"
     description: "a useful op"
     authors:
