scijava-meta: fix IntelliJ warnings

ctrueden · ctrueden · commit 22fbc05712db · 2024-05-30T19:29:02.000-05:00
diff --git a/scijava-meta/src/main/java/org/scijava/meta/POM.java b/scijava-meta/src/main/java/org/scijava/meta/POM.java
@@ -47,7 +47,7 @@
  */
 public class POM extends XML implements Comparable<POM>, Versioned {
 
-	private String version;
+	private volatile String version;
 
 	/** Parses a POM from the given file. */
 	public POM(final File file) throws IOException {
@@ -273,8 +273,7 @@ private static POM findPOM(final URL location, final String groupId,
 					// known groupId and artifactId; grab it directly
 					final String pomPath = "META-INF/maven/" + groupId + "/" +
 						artifactId + "/pom.xml";
-					final URL pomURL = new URL("jar:" + location.toString() + "!/" +
-						pomPath);
+					final URL pomURL = new URL("jar:" + location + "!/" + pomPath);
 					return new POM(pomURL);
 				}
 			}
@@ -347,7 +346,7 @@ public static List<POM> allPOMs() {
 	 * suffix will be considered <em>less than</em> the one without a suffix. The
 	 * reason for this is to accommodate the
 	 * <a href="http://semver.org/">SemVer</a> versioning scheme's usage of
-	 * "prerelease" version suffixes. For example, {@code 2.0.0} will compare
+	 * "pre-release" version suffixes. For example, {@code 2.0.0} will compare
 	 * greater than {@code 2.0.0-beta-1}, whereas {@code 2.0.0} will compare less
 	 * than {@code 2.0.0.1}.</li>
 	 * </ul>
diff --git a/scijava-meta/src/main/java/org/scijava/meta/XML.java b/scijava-meta/src/main/java/org/scijava/meta/XML.java
@@ -77,8 +77,8 @@ public class XML {
 	/** XPath evaluation mechanism. */
 	private final XPath xpath;
 
-	private final boolean debug = "debug".equals(System.getProperty(
-		"scijava.log.level"));
+	private final boolean debug =
+		"debug".equals(System.getProperty("scijava.log.level"));
 
 	/** Parses XML from the given file. */
 	public XML(final File file) throws IOException {
@@ -122,7 +122,7 @@ public XML(final String path, final Document doc) {
 			System.err.println(Classes.location(XPathFactory.class));
 		}
 
-		XPath xp = null;
+		XPath xp;
 		final Thread thread = Thread.currentThread();
 		final ClassLoader contextClassLoader = thread.getContextClassLoader();
 		try {
@@ -219,7 +219,7 @@ public String toString() {
 	/** Gets the CData beneath the given node. */
 	public static String cdata(final Node item) {
 		final NodeList children = item.getChildNodes();
-		if (children == null || children.getLength() == 0) return null;
+		if (children.getLength() == 0) return null;
 		for (int i = 0; i < children.getLength(); i++) {
 			final Node child = children.item(i);
 			if (child.getNodeType() != Node.TEXT_NODE) continue;
@@ -231,7 +231,7 @@ public static String cdata(final Node item) {
 	/** Gets the CData beneath the given element's specified child. */
 	public static String cdata(final Element el, final String child) {
 		NodeList children = el.getElementsByTagName(child);
-		if (children == null || children.getLength() == 0) return null;
+		if (children.getLength() == 0) return null;
 		return cdata(children.item(0));
 	}
 
@@ -269,8 +269,7 @@ private static Document loadXML(final File file) throws IOException {
 	/** Loads an XML document from the given URL. */
 	private static Document loadXML(final URL url) throws IOException {
 		try (final InputStream in = url.openStream()) {
-			final Document document = loadXML(in);
-			return document;
+			return loadXML(in);
 		}
 	}
 
