Test the Types.typeParamsOf methods

ctrueden · ctrueden · commit 09a3940cd172 · 2024-05-28T15:27:20.000-05:00
Unfortunately, Types.typeParamsOf(Type, Class) seems buggy.
See commented out assertions in this commit for an example.
diff --git a/scijava-types/src/test/java/org/scijava/types/TypesTest.java b/scijava-types/src/test/java/org/scijava/types/TypesTest.java
@@ -32,6 +32,7 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.junit.jupiter.api.Assertions.assertSame;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -182,6 +183,28 @@ class Struct {
 		assertSame(int[].class, paramClass);
 	}
 
+	/** Tests {@link Types#typeParamsOf(Class, Class)}. */
+	@Test
+	public void testTypeParamsOfClass() {
+		final Type[] argTypesRaw = Types.typeParamsOf(IntegerThing.class, Thing.class);
+		assertEquals(1, argTypesRaw.length);
+		assertSame(Integer.class, argTypesRaw[0]);
+	}
+
+	/** Tests {@link Types#typeParamsOf(Type, Class)}. */
+	@Test
+	public <U extends IntegerThing> void testTypeParamsOfType() {
+		final Type arg = new Nil<U>() {}.type();
+		final Type[] argTypes = Types.typeParamsOf(arg, Thing.class);
+		assertNotNull(argTypes);
+		// FIXME: argTypes should return {Integer.class}, not {}.
+		//  In contrast, the correct result is returned by:
+		//  - Types.typeParamOf(arg, Thing.class, 0)
+		//  - Types.typeParamsOf(IntegerThing.class, Thing.class)
+//		assertEquals(1, argTypes.length);
+//		assertSame(Integer.class, argTypes[0]);
+	}
+
 	/** Tests {@link Types#isAssignable(Type, Type)}. */
 	@Test
 	public void testIsAssignable() {
