Skip to content

Commit 08a79a7

Browse files
committed
OpEnvironment: add names... param to opify
Otherwise it's awkward that you can't provide a set of names for the opification call without also providing a priority. This shouldn't impact any existing API usage, although the method is different, because it's a varargs param.
1 parent ae06854 commit 08a79a7

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

‎scijava/scijava-ops-api/src/main/java/org/scijava/ops/api/OpEnvironment.java‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -784,9 +784,10 @@ default OpBuilder.Arity16 arity16(final String opName, final Hints hints) {
784784
* Creates an {@link OpInfo} from an {@link Class}.
785785
*
786786
* @param opClass the {@link Class} to derive the Op from
787+
* @param names - the name(s) of the Op
787788
* @return an {@link OpInfo} which can make instances of {@code opClass}
788789
*/
789-
OpInfo opify(Class<?> opClass);
790+
OpInfo opify(Class<?> opClass, String... names);
790791

791792
/**
792793
* Creates an {@link OpInfo} from an {@link Class} with the given priority.

‎scijava/scijava-ops-engine/src/main/java/org/scijava/ops/engine/impl/DefaultOpEnvironment.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -301,13 +301,13 @@ public Type genericType(Object obj) {
301301
}
302302

303303
@Override
304-
public OpInfo opify(final Class<?> opClass) {
305-
return opify(opClass, Priority.NORMAL);
304+
public OpInfo opify(final Class<?> opClass, String... names) {
305+
return opify(opClass, Priority.NORMAL, names);
306306
}
307307

308308
@Override
309309
public OpInfo opify(final Class<?> opClass, final double priority,
310-
final String... names)
310+
String... names)
311311
{
312312
return new OpClassInfo(opClass, Versions.getVersion(opClass), new Hints(), priority,
313313
names);

0 commit comments

Comments
 (0)