inferTypeVariables: avoid recursive bounds

hinerm · hinerm · commit 0040f803ffdd · 2024-01-26T11:10:59.000-06:00
Previously we were recursively checking bounds of type variables even if
those bounds were themselves recursive. This would create duplicate
mappings that worked incidentally because the values were the same
(since recursive) but this behavior broke in the change to recurse to
raw types instead (avoiding infinite recursion errors)
diff --git a/scijava-types/src/main/java/org/scijava/types/inference/GenericAssignability.java b/scijava-types/src/main/java/org/scijava/types/inference/GenericAssignability.java
@@ -605,7 +605,7 @@ private static void inferTypeVariables(TypeVariable<?> type, Type inferFrom,
 						throw new TypeInferenceException();
 					}
 				}
-				else if (!Types.isRecurisveBound(type, bound)) {
+				else if (!Types.isRecursiveBound(type, bound)) {
 					// Else go into recursion as we encountered a new var.
 					inferTypeVariables(bound, inferFrom, typeMappings);
 				}

Original file line number	Diff line number	Diff line change
`@@ -605,7 +605,7 @@ private static void inferTypeVariables(TypeVariable<?> type, Type inferFrom,`
`605`	`605`	`throw new TypeInferenceException();`
`606`	`606`	`}`
`607`	`607`	`}`
`608`		`- else if (!Types.isRecurisveBound(type, bound)) {`
	`608`	`+ else if (!Types.isRecursiveBound(type, bound)) {`
`609`	`609`	`// Else go into recursion as we encountered a new var.`
`610`	`610`	`inferTypeVariables(bound, inferFrom, typeMappings);`
`611`	`611`	`}`