Sipmlify getWrapperClass#93
Merged
Merged
Conversation
gselzer
force-pushed
the
scijava/scijava-ops-engine/simplify-op-wrapping
branch
2 times, most recently
from
1ad17e0 to
b98addf
Compare
This way, we don't call an instanceof check on every wrapper class. We instead call contains on the inheritance hierarchy, which should be both more robust and faster
gselzer
force-pushed
the
scijava/scijava-ops-engine/simplify-op-wrapping
branch
from
b98addf to
3571f19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made these changes while investigating scijava/scijava#51. It seems like there is no longer any errors thrown with the
DoubleFunctiontype, unless we make following Op call without making a `DoubleFunctionOpWrapper:In the case someone makes this Op call, they'll get a
ClassCastExceptionbecause the return is wrapped by theFunction1OpWrapper- i.e. it is aFunction, but not aDoubleFunction. You'll need aDoubleFunctionOpWrapperto get that type back, and this PR adds a warning that is logged when it is attempted.I also made a change to the way that we find the wrapper; now, we no longer call
instanceofon every wrapper class. We instead call contains on the inheritance hierarchy, which should be both more robust and faster.Closes scijava/scijava#51