Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Simplify hints by moving implementation upstream - #89

Merged
hinerm merged 1 commit into
mainfrom
scijava/scijava-ops-api/simplify-hints
Aug 30, 2023
Merged

hinerm merged 1 commit into
mainfrom
scijava/scijava-ops-api/simplify-hints

Conversation

@gselzer

@gselzer gselzer commented Aug 22, 2023

Copy link
Copy Markdown
Member

This PR moves the DefaultHints implementation upstream, as because @ctrueden points out in scijava/scijava#82, the existence of a DefaultHints implementation is confusing, and because we haven't yet found a use case where someone would want multiple implementations. Of course, this change doesn't prevent subclassing - maybe it will in fact make it easier

@gselzer gselzer added the enhancement New feature or request label Aug 22, 2023
@gselzer
gselzer requested a review from hinerm August 22, 2023 21:34
@gselzer gselzer self-assigned this Aug 22, 2023
@gselzer gselzer linked an issue Aug 23, 2023 that may be closed by this pull request

@hinerm hinerm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I even like the improved lambdas 😂

@hinerm
hinerm merged commit 5e48faa into main Aug 30, 2023
@hinerm
hinerm deleted the scijava/scijava-ops-api/simplify-hints branch August 30, 2023 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Finalize naming of hints

2 participants