Skip to content

Conversation

@gselzer
Copy link
Member

@gselzer gselzer commented Aug 11, 2023

This PR introduces a set of drafts for wiki-like documentation for using the SciJava Ops/ImageJ Ops2 framework, addressing the points of need described in scijava/scijava#124.

@hinerm let me know if there's anything you think I left out. We also have to figure out where they should live.

@gselzer gselzer requested review from ctrueden and hinerm August 11, 2023 19:16
@gselzer gselzer self-assigned this Aug 11, 2023
@gselzer gselzer force-pushed the imagej/imagej-ops2-tutorial/docs branch from ae61749 to 651db80 Compare August 11, 2023 19:20
@gselzer gselzer force-pushed the imagej/imagej-ops2-tutorial/docs branch from 651db80 to c6d86d5 Compare August 11, 2023 19:21
Copy link
Member

@elevans elevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! I learned a few things about the op builder which I found very useful.

@gselzer
Copy link
Member Author

gselzer commented Aug 18, 2023

Thanks for the review @elevans - I think I addressed all of your comments. Let me know if you see anything else!

@elevans
Copy link
Member

elevans commented Aug 22, 2023

I think this is great! Ready to merge 👍

@gselzer gselzer marked this pull request as ready for review August 29, 2023 21:24
Copy link
Member

@hinerm hinerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gselzer Nice work. I especially like the migration walkthrough. I'd just like to see a couple sections expanded and revised.

@gselzer
Copy link
Member Author

gselzer commented Sep 1, 2023

@hinerm thanks for the review! I think I've addressed all of your comments - let me know what you think!

@gselzer gselzer requested a review from hinerm September 1, 2023 21:02
@hinerm hinerm merged commit d610c70 into main Sep 12, 2023
@hinerm hinerm deleted the imagej/imagej-ops2-tutorial/docs branch September 12, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants