Throw ValidityException instead of saving it#83
Merged
Conversation
Unrelated to the PR, but didn't want to forget this and too small for an issue
This change also make them RuntimeExceptions
hinerm
force-pushed
the
scijava/scijava-ops-api/remove-validity-exception
branch
from
9aa6ba9 to
eef0e77
Compare
hinerm
approved these changes
Aug 8, 2023
Member
The failures are not getting tested (per uses of ValidityException.problems()) except in the recent OpMethodDependencyPositionTest. I think the tests should be looked at with scijava/scijava#105, because |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the
OpInfoAPI aroundValidityExceptions - instead of saving theException, the constructor now throws theException. Then, duringOpInfoconstruction, we now catch theseExceptionsand continue on.We still have to figure out how to log the
Exceptions, so that developers can determine how to make their ops valid - I'm tempted to just wait until #82 is merged, because logging would then be quite easy.Question for the reviewer: Are failures getting tested? Should we add additional tests? What might those tests look like?