Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Purge scijava-common from most incubator projects - #63

Merged
ctrueden merged 18 commits into
mainfrom
purge-sjc2-harder
Oct 21, 2022
Merged

ctrueden merged 18 commits into
mainfrom
purge-sjc2-harder

Conversation

@ctrueden

Copy link
Copy Markdown
Member

This work is a followup to #57, which began the process of removing usage of scijava-common from various modules. There were still quite a few places were being used even after #57, however, which this PR addresses. The only remaining usage of scijava-common now (AFAIK) is in scijava-persist, which we will audit at a later time.

This migrates the code from imagej-mesh, without introducing any
scijava-common dependency:

* Use equivalent scijava-collections classes, not org.scijava.util.*Array.
* Use new ArrayIO methods from scijava-testutil, not io.scif.img.IO.
It was built on the old SciJava Common, and nothing used it.

Later, we might need to introduce a new scijava-specific
plugin mechanism, but we do not need it yet...
We have this lightweight module specifically to unify these constants...
let's use it.
* Replace org.scijava.util with scijava-collections and scijava-meta.
* Use scijava-priority for priority constants.
* Stop implementing the old Cancelable and SingletonPlugin interfaces.
  We will need to provide a suitable replacement for cancelation later.
* Remove obsolete POM and module-info configuration.
* Use try-with-resources where appropriate.
* Remove unused exceptions from throws declarations.
@ctrueden
ctrueden merged commit 3d26439 into main Oct 21, 2022
@ctrueden
ctrueden deleted the purge-sjc2-harder branch October 21, 2022 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant