Repository navigation
Update abstract tests - #62
Conversation
The net.imagej.ops2.features package exists only in the test scope, thus it is not exported in the source module-info.java. This made tests using that package (any feature test) unusable in Eclipse, for example. This commit works around the issue by moving the AbstractFeatureTest to the base net.imagej.ops2 directory, which is already being exported.
* The static helper methods all include the name "Relative" to differentiate them from the non-static methods. * Added a non-static unsigned byte opener * Unsigned byte method naming is now consistent
There was a problem hiding this comment.
Thanks for making changes @hinerm!
I don't have much of a problem with the individual changes, and I appreciate that you did the minimum to make the build work.
I am a bit concerned, though, about the idea of putting all of the abstract tests in the top-level folder. My main concern is that this practice will likely conflict with the subpackage dependency rule reinstated in #59, so conforming this rule will limit what we do with abstract classes in tests. But, I didn't see anything in this PR that would break the rules...
I also dislike the fact that we have to make this change for an IDE. I don't think I've had this issue in IntelliJ. Is there any way we could use --patch-module in the Eclipse configuration?
Here is how surefire patches the module
|
@gselzer I agree that this change is unfortunate, but it gets the build passing, and we need that now. How about this plan:
|
Well, the build is passing, just not in Eclipse.
That sounds fine, but are we really sure that the correct fix will take so long to implement? It seems like you could just do something like this; if that works, is there some way that we could save those args as state somewhere in JPMS projects? |
It's unfortunate that it works in IntelliJ and not Eclipse, but I do think we should strive for IDE compatibility.
Understandable. I checked out #59 and tested and confirmed these changes still pass there. I think that if you have a series of (sub)packages, Also I like having the
If it was for production code then I think it would be worth more investigation, but since it's just the tests and just for running manually in Eclipse I think we will get very minimal return on time invested, until a point where there is a demonstrable need to have |
@gselzer the tests also do not work for me in IntelliJ. On which goes away with this patch. @ctrueden do you have any objections or can we merge? |
ctrueden
left a comment
There was a problem hiding this comment.
This is a step forward for immediate development. We always have the flexibility to refactor any test-scope classes and packages; we're not boxing ourselves into any corners design-wise.
|
oh good* news, Everything passes from the command line. ☠️ *I've chosen to contextualize bad news as good news |
|
@ctrueden said:
Yes, good point. Thank you both for working on this! @hinerm said:
I'm pretty certain this is a bug in imglib2's EDIT: Found it |
|
and I think I was wrong.. I cleaned and re-ran everything and the exception is consistently the AIOOBE it looks like. Yay! |
Closes scijava/scijava#94