This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Restore Package Rules - #59
Merged
Merged
Conversation
gselzer
marked this pull request as draft
April 15, 2022 19:15
gselzer
force-pushed
the
scijava/scijava-ops-engine/restore-package-rules
branch
5 times, most recently
from
May 13, 2022 22:22
003a120 to
2729c24
Compare
Member
Author
|
This would close scijava/scijava#92 |
24 of 25 tasks
Merged
Member
|
This PR needs a |
gselzer
force-pushed
the
scijava/scijava-ops-engine/restore-package-rules
branch
from
August 31, 2023 18:12
2729c24 to
9b54563
Compare
gselzer
marked this pull request as ready for review
August 31, 2023 18:12
gselzer
force-pushed
the
scijava/scijava-ops-engine/restore-package-rules
branch
from
August 31, 2023 19:30
9b54563 to
dc9b2f6
Compare
Member
Author
|
@ctrueden @hinerm this PR has been brought up to date, unfortunately through the process of basically doing it all over again. I'd suggest we fast-track this PR, with the fear of having to do it all over again. For those who review, please pay attention to the API added to the
To restore the package rules, we need to hide |
This reverts commit b052d25. This did not seem to fix the builds.
hinerm
force-pushed
the
scijava/scijava-ops-engine/restore-package-rules
branch
from
September 14, 2023 19:52
dc9b2f6 to
e7bbccf
Compare
hinerm
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-establishes the package rules of scijava-maven-plugin. To do this,
OpEnvironment,OpHistory,TypeReifierandLoggerFactorywere rewritten asPrioritizedimplementations.We then added
Discoverer.discoverMax()andDiscoverer.discoverMin(), able to discoverer the highest/lowest priority implementations for anyClassimplementingComparable.This makes it trivial to discover
DefaultOpEnvironment. Specifically, we can useOpEnvironment.getOpEnvironment()to get the highest-priorityOpEnvironment. This is similar to the callContext.getService(OpService.class)in SciJava Common/ImageJ Ops.Remaining questions:
LoggerFactorythe discoverable interface instead ofLoggerfor convenience reasons (theLoggerimplementation has constructor arguments). Is there a reason to keepLoggerFactory? Can we remove the constructor arguments of theLoggerimplementations?Cannot be merged until #55 is merged, as this work is built on top of that work.