This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Clean ProvenanceTest - #56
Merged
Merged
Conversation
24 of 25 tasks
ctrueden
force-pushed
the
scijava/scijava-ops-engine/clean-provenance-test
branch
2 times, most recently
from
July 1, 2022 22:11
75a6068 to
7475c2b
Compare
The things that we needed in SciJava Ops API were better suited to live in the classes that used them. With those things moved, there was no reason to keep OpUtils in SciJava Ops API.
ctrueden
force-pushed
the
scijava/scijava-ops-engine/clean-provenance-test
branch
from
July 1, 2022 22:24
7475c2b to
d4fb9c9
Compare
ctrueden
approved these changes
Jul 1, 2022
| import java.util.Collections; | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.*; |
Member
There was a problem hiding this comment.
Since when did we decide to start using wildcard imports? I don't remember discussing this.
|
|
||
| /** Gets the op's input parameters. */ | ||
| default List<Member<?>> inputs() { | ||
| return OpUtils.inputs(struct()); |
Member
There was a problem hiding this comment.
Post-move, does anything still use OpUtils.inputs to obtain the members of a struct? Or can we slim down the OpUtils methods henceforth? It's not in an exported anymore, right? So we could trim it?
| Function<Double, Thing> actual = ops // | ||
| .opFromSignature(signature, specialType); | ||
| // Assert Op similarity | ||
| Assertions.assertTrue(wrappedOpEquality(mapper, actual)); |
Member
There was a problem hiding this comment.
I've been wondering... we used to use import static with JUnit 4. Now that we are on JUnit 5, would it make sense to do the same, statically importing used Assertions methods? Or do you prefer the verbosity this way? It's more consistent with everything else, but I ask because it's a break from previous JUnit convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is focused on two actions, both in
ProvenanceTest.Firstly, it makes better assertions in the tests dealing with Op creation from a
Stringsignature. See scijava/scijava#83 for the motivation behind this.Secondly, it cleans and formats the file.
Closes scijava/scijava#83