Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Move OpUtils back into SciJava Ops Engine - #55

Merged
hinerm merged 1 commit into
mainfrom
scijava/scijava-ops-api/op-utils-to-engine
Nov 22, 2022
Merged

hinerm merged 1 commit into
mainfrom
scijava/scijava-ops-api/op-utils-to-engine

Conversation

@gselzer

@gselzer gselzer commented Jan 21, 2022

Copy link
Copy Markdown
Member

d521c62 moved OpUtils into SciJava Ops API because some API classes (OpInfo and OpCandidate, to name a few) used its functionality.

This PR moves OpUtils back into SciJava Ops Engine. This was made possible by the migration of relevant code into the API classes needing it. For example, OpUtils.inputs(Struct struct) became OpInfo.inputs(). With these migrations, no code in API depended on OpUtils, allowing it to move back into SciJava Ops Engine

Closes scijava/scijava#70

@gselzer
gselzer force-pushed the scijava/scijava-ops-api/op-utils-to-engine branch from 710736f to 2c271c1 Compare April 1, 2022 18:51
@gselzer gselzer mentioned this pull request Apr 15, 2022
1 task
@ctrueden
ctrueden force-pushed the scijava/scijava-ops-api/op-utils-to-engine branch from 2c271c1 to 6966d2f Compare October 31, 2022 20:41
@ctrueden

Copy link
Copy Markdown
Member

I rebased this PR on top of #58.

However, the sole commit of this PR, moving OpUtils back into scijava-ops-engine, has already been accomplished with fd6f510, which was done as part of #56. So... this PR needs some extra scrutiny to ensure the changes here are actually desired, and not rolling back desirable tweaks.

@ctrueden
ctrueden force-pushed the scijava/scijava-ops-api/op-utils-to-engine branch from 6966d2f to 8483405 Compare November 8, 2022 14:46
@ctrueden

ctrueden commented Nov 8, 2022

Copy link
Copy Markdown
Member

@gselzer Could you please have a quick look at this PR, now that it is adjusted on top of all the other work? Are these changes good? Or should we close it unmerged? Tentatively they look like good changes to me (removing unused imports and improving javadoc), but there are also some public method removals, and changes to reduce the number of OpUtils usages. I think you're the best person to know quickly whether this was the intended direction.

@gselzer

gselzer commented Nov 8, 2022

Copy link
Copy Markdown
Member Author

@ctrueden this was the intended direction. Although the changes no longer deal with the purpose of this PR, I think they should be merged.

@ctrueden

ctrueden commented Nov 8, 2022

Copy link
Copy Markdown
Member

@gselzer Great, thanks! Then we'll rebase+merge it as soon as #58 is done! 🍻

This commit began as a migration of OpUtils back to SciJava Ops Engine.
But since writing this patch, that class already moved back to
scijava-ops-engine in fd6f510. So this
patch is now just remnants of that work, in case any of it is useful.

Signed-off-by: Curtis Rueden <ctrueden@wisc.edu>
Signed-off-by: Mark Hiner <hinerm@gmail.com>
@hinerm
hinerm force-pushed the scijava/scijava-ops-api/op-utils-to-engine branch from 8483405 to 0bae5b0 Compare November 22, 2022 14:47
@hinerm
hinerm merged commit 6dbbc7f into main Nov 22, 2022
@hinerm
hinerm deleted the scijava/scijava-ops-api/op-utils-to-engine branch November 22, 2022 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Remove OpUtils from SciJava Ops API

3 participants