Repository navigation
Move OpUtils back into SciJava Ops Engine - #55
Conversation
710736f to
2c271c1
Compare
2c271c1 to
6966d2f
Compare
|
I rebased this PR on top of #58. However, the sole commit of this PR, moving |
6966d2f to
8483405
Compare
|
@gselzer Could you please have a quick look at this PR, now that it is adjusted on top of all the other work? Are these changes good? Or should we close it unmerged? Tentatively they look like good changes to me (removing unused imports and improving javadoc), but there are also some public method removals, and changes to reduce the number of |
|
@ctrueden this was the intended direction. Although the changes no longer deal with the purpose of this PR, I think they should be merged. |
This commit began as a migration of OpUtils back to SciJava Ops Engine. But since writing this patch, that class already moved back to scijava-ops-engine in fd6f510. So this patch is now just remnants of that work, in case any of it is useful. Signed-off-by: Curtis Rueden <ctrueden@wisc.edu> Signed-off-by: Mark Hiner <hinerm@gmail.com>
8483405 to
0bae5b0
Compare
d521c62 moved
OpUtilsinto SciJava Ops API because some API classes (OpInfoandOpCandidate, to name a few) used its functionality.This PR moves
OpUtilsback into SciJava Ops Engine. This was made possible by the migration of relevant code into the API classes needing it. For example,OpUtils.inputs(Struct struct)becameOpInfo.inputs(). With these migrations, no code in API depended onOpUtils, allowing it to move back into SciJava Ops EngineCloses scijava/scijava#70