Repository navigation
Revisions on the revisionson on view-javadoc - #54
Conversation
Otherwise it messes with the output in the build
It wasn't used
We didn't use it
We only use this method in one place, and we are just creating that Supplier in the method call. Let's just remove it.
325a71e to
5a09cbd
Compare
| final OpDependency annotation) | ||
| { | ||
| this(() -> key, () -> description, type, annotation); | ||
| this.key = key; |
There was a problem hiding this comment.
This looks like more than just "cleaning" to me. A better commit message explaining what this commit actually does would have been nice.
| return type; | ||
| } | ||
| } | ||
|
|
| String getKey(); | ||
|
|
||
| /** Description of the member. */ | ||
| /** Non-null description. The default description is an empty string */ |
There was a problem hiding this comment.
Second sentence needs a period.
| // will be written to, but immutable parameters cannot be changed in | ||
| // such a manner, so it makes no sense to label them as such. | ||
| final String error = "Immutable " + m.getIOType() + " parameter: " + | ||
| name.get() + " (" + type.getName() + " is immutable)"; |
There was a problem hiding this comment.
To be fair, we are only calling the supplier when there is an error. So, there is a chance that performance could be impacted. But the fact that the only supplier is just m.getKey() and presumably that's O(1), with no additional memory allocation... means that performance is highly unlikely to be a problem here. At least for this use case! But the checkValidity method is public static... should we be concerned in general? Does/will anyone else ever call this? If not: maybe we should make this private? Or if so, maybe the supplier is still a good idea?
Addresses the revisions requested in #47