Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Convert SciJava Types Tests to JUnit 5 - #50

Merged
ctrueden merged 1 commit into
mainfrom
scijava/scijava-types/junit-5
Jul 1, 2022
Merged

ctrueden merged 1 commit into
mainfrom
scijava/scijava-types/junit-5

Conversation

@gselzer

@gselzer gselzer commented Nov 16, 2021

Copy link
Copy Markdown
Member

This PR does what it says above.

The POM only listed org.junit and org.junit.jupiter.api as dependencies, which is very strange. Furthermore, it would only run JUnit 4 tests, which represented very few of this project's tests. This PR replaces org.junit with org.junit.jupiter.engine, and converts all tests still running JUnit 4.

TODO:

@ctrueden ctrueden self-assigned this Nov 22, 2021
@gselzer
gselzer force-pushed the scijava/scijava-types/junit-5 branch from 99b3994 to 6e6973e Compare November 29, 2021 22:18
@gselzer
gselzer force-pushed the scijava/scijava-types/junit-5 branch from 6e6973e to 3d0e39e Compare December 3, 2021 17:34
@gselzer
gselzer force-pushed the scijava/scijava-types/junit-5 branch from 3d0e39e to cb715c3 Compare January 14, 2022 17:16
@ctrueden
ctrueden force-pushed the scijava/scijava-types/junit-5 branch from cb715c3 to 902bb70 Compare June 30, 2022 22:26

@ctrueden ctrueden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One component down, eight more to go. 😅

@ctrueden
ctrueden merged commit 4e7ddf3 into main Jul 1, 2022
@ctrueden
ctrueden deleted the scijava/scijava-types/junit-5 branch July 1, 2022 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants