Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

View-Javadoc Revisions - #47

Merged
ctrueden merged 13 commits into
mainfrom
scijavva/scijava-ops-engine/view-javadoc-revisions
Dec 6, 2021
Merged

ctrueden merged 13 commits into
mainfrom
scijavva/scijava-ops-engine/view-javadoc-revisions

Conversation

@gselzer

@gselzer gselzer commented Nov 15, 2021

Copy link
Copy Markdown
Member

Implements suggestions from @ctrueden in #28

@gselzer
gselzer force-pushed the scijavva/scijava-ops-engine/view-javadoc-revisions branch from 1a8f78f to 01d21c4 Compare November 16, 2021 19:17
@ctrueden ctrueden self-assigned this Nov 22, 2021
TODO: This adds a significant amount of time to the build. We should
look at lazily obtaining the names/descriptions
We aren't using it...
This prevents any Javadoc parsing from occuring until someone calls
getKey() or getDescription() on an Op's Struct's member (which might
happen for an exception message, or for a help op)
This functionality is covered by the lazily-generated ParameterDatas
@ctrueden
ctrueden force-pushed the scijavva/scijava-ops-engine/view-javadoc-revisions branch from 01d21c4 to 8a22341 Compare December 6, 2021 21:26
@ctrueden

ctrueden commented Dec 6, 2021

Copy link
Copy Markdown
Member

Confirmed that all commits compile with passing tests after the rebase.

Comment thread imagej/imagej-ops2/pom.xml Resolved
Comment thread scijava/scijava-discovery/pom.xml Resolved
@ctrueden
ctrueden merged commit bcc959f into main Dec 6, 2021
@ctrueden
ctrueden deleted the scijavva/scijava-ops-engine/view-javadoc-revisions branch December 6, 2021 22:42
@gselzer

gselzer commented Jan 14, 2022

Copy link
Copy Markdown
Member Author

Got most of the way through this, will finish it next week!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants