This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Conversation
Previously we prioritized a setHints taking only the whole Hint. Now we prioritize a Hint composed of the String hintType and the Object value. We also add a getDelimiter method to provide an implementation-independent way to get the delimiter. In this way we no longer tie ourselves to a single delimiter.
Suggested by ctrueden on Gitter. This branch wasn't intended for these changes, but it is nice to get them in :)
gselzer
force-pushed
the
scijava/scijava-ops/setHitns
branch
from
July 15, 2021 16:34
f7754fb to
0b798b2
Compare
Member
|
After b4169e9, this PR might be obsolete. Or it might have some goodness to be extracted. Scrutiny needed. |
Member
Author
|
Looking through the diff, I can't find anything that I think needs to be ported! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we prioritized a setHints taking only the whole Hint. Now we
prioritize a Hint composed of the String hintType and the Object value.
We also add a getDelimiter method to provide an
implementation-independent way to get the delimiter. In this way we no
longer tie ourselves to a single delimiter.
Inspired by a conversation with @ctrueden on Gitter
The singular commit builds with passing tests