Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Prioritize a more powerful version of setHints - #37

Closed
gselzer wants to merge 2 commits into
mainfrom
scijava/scijava-ops/setHitns
Closed

gselzer wants to merge 2 commits into
mainfrom
scijava/scijava-ops/setHitns

Conversation

@gselzer

@gselzer gselzer commented Jul 15, 2021

Copy link
Copy Markdown
Member

Previously we prioritized a setHints taking only the whole Hint. Now we
prioritize a Hint composed of the String hintType and the Object value.
We also add a getDelimiter method to provide an
implementation-independent way to get the delimiter. In this way we no
longer tie ourselves to a single delimiter.

Inspired by a conversation with @ctrueden on Gitter

The singular commit builds with passing tests

gselzer added 2 commits July 15, 2021 11:02
Previously we prioritized a setHints taking only the whole Hint. Now we
prioritize a Hint composed of the String hintType and the Object value.
We also add a getDelimiter method to provide an
implementation-independent way to get the delimiter. In this way we no
longer tie ourselves to a single delimiter.
Suggested by ctrueden on Gitter.

This branch wasn't intended for these changes, but it is nice to get
them in :)
@ctrueden

ctrueden commented May 3, 2023

Copy link
Copy Markdown
Member

After b4169e9, this PR might be obsolete. Or it might have some goodness to be extracted. Scrutiny needed.

@gselzer

gselzer commented Oct 16, 2023

Copy link
Copy Markdown
Member Author

Looking through the diff, I can't find anything that I think needs to be ported!

@gselzer gselzer closed this Oct 16, 2023
@gselzer
gselzer deleted the scijava/scijava-ops/setHitns branch January 9, 2024 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants