This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Add RAI focusers - #128
Merged
Merged
Add RAI focusers#128
Conversation
gselzer
commented
Feb 27, 2024
gselzer
left a comment
Member
Author
There was a problem hiding this comment.
Nice addition but lots of cleanup to do
gselzer
force-pushed
the
scijava-ops-image/rai-focusers
branch
12 times, most recently
from
February 29, 2024 17:37
237db86 to
197c670
Compare
gselzer
force-pushed
the
scijava-ops-image/rai-focusers
branch
from
February 29, 2024 17:40
197c670 to
cd33533
Compare
gselzer
marked this pull request as ready for review
February 29, 2024 17:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds focusers for
RandomAccessibleIntervals. It is left as a draft as I believe that there is more cleanup (testing, optimizations, unnecessary changes, etc.) to do.Notably, I made the decision that for image forms,
RandomAccessibleInterval<?>is the shared simplified data structure - I believe this aligns with the work that @hinerm is doing in #123. The notable alternative would be something likeRandomAccessibleInterval<DoubleType>, but that could involve lots of unnecessary casting.