Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Add RAI focusers - #128

Merged
gselzer merged 1 commit into
mainfrom
scijava-ops-image/rai-focusers
Feb 29, 2024
Merged

gselzer merged 1 commit into
mainfrom
scijava-ops-image/rai-focusers

Conversation

@gselzer

@gselzer gselzer commented Feb 27, 2024

Copy link
Copy Markdown
Member

This PR adds focusers for RandomAccessibleIntervals. It is left as a draft as I believe that there is more cleanup (testing, optimizations, unnecessary changes, etc.) to do.

Notably, I made the decision that for image forms, RandomAccessibleInterval<?> is the shared simplified data structure - I believe this aligns with the work that @hinerm is doing in #123. The notable alternative would be something like RandomAccessibleInterval<DoubleType>, but that could involve lots of unnecessary casting.

@gselzer gselzer added the enhancement New feature or request label Feb 27, 2024
@gselzer gselzer self-assigned this Feb 27, 2024

@gselzer gselzer left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition but lots of cleanup to do

@gselzer
gselzer force-pushed the scijava-ops-image/rai-focusers branch 12 times, most recently from 237db86 to 197c670 Compare February 29, 2024 17:37
@gselzer
gselzer force-pushed the scijava-ops-image/rai-focusers branch from 197c670 to cd33533 Compare February 29, 2024 17:40
@gselzer
gselzer marked this pull request as ready for review February 29, 2024 17:45
@gselzer
gselzer merged commit 0b65d2b into main Feb 29, 2024
@gselzer
gselzer deleted the scijava-ops-image/rai-focusers branch February 29, 2024 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant