Repository navigation
Add OpenCV ops - #123
Add OpenCV ops#123
Conversation
There was a problem hiding this comment.
Thanks so much for all this work @hinerm!
Couple of additional comments I have:
- I think it is important to add some mechanism to add descriptions to parameters. Ideally, we'd be able to scrape the javadoc, but that could be tricky.
How much additional effort would it require to add some simplifiers on top of this, so that you can call OpenCV functions with(I see you mentioned this as a TODO, which is great)RAIs?
I think that the only thing you can do is enable users to set a priority in your allowlist...
As far as names go, if you're accessing the methods via reflection, then you should have access to the Like I mentioned in my review, I think that short of actually parsing the
Yeah, like I mentioned in my review I have concerns that this will hold up.
The array operations may be useful, but we could also add more later.
Just added in some comments where I found aliases in SciJava Ops that differed.
None here! |
|
One final comment - have you thought about the case where there are multiple methods of the same name (i.e. they have different parameters) - your YAML allowlist schema may want to have a way to specify some but not others. |
172a74a to
3a162e3
Compare
Yeah this was the intent, to avoid having to explicitly include each method.. if you're making decisions on each method individually, I would consider just writing the
Yeah I think I like this, and we can just say |
e544731 to
8a69b9f
Compare
ca924fe to
e7af1dd
Compare
|
@gselzer do you mind taking a quick look to see if anything glaring stands out? it does not need to be exhaustive. |
This project has no source code.
Use priority, description, type and alias keys in the shorthand YAML (removing need for an explicit containers specification).
This will make the output op.yaml deterministic
Without priority being specified these will clash with each other.
Since we're translating between data types the appropriate framework pathway is simplification.
These are necessary for simplification and adaptation.
This is necessary for the provided RAI copy ops
These are just guarantees that it is possible for the framework to make satisfy these calls.
We need to compare castability to original method parameters, not necessarily the simplifiers (which will give an erroneous false positive in the case of identity focusers)
Remove unused deps, move what we can to runtime/test scope, and add undeclared imglib2 dep.
Hooray it's an external library wrapped into Ops with no code.
Closes scijava/scijava#158
Questions/notes:
priorityof the wrapped ops. Thoughts?Computerheuristic is stupid and tailored to OpenCV. I saw it as something we could expand support for as needed, but wanted to mention it.Remaining tasks: