Scijava types/recursive stack overflow#120
Merged
Merged
Conversation
94ab0c1 to
d45c316
Compare
Just a convenience method for identifying recursive parameterization.
Recursively parameterized types can cause stack overflows when recursively descending type hierarchies if not handled carefully. In this case we continue the recursive descent using the raw type, removing the risk of infinite recursion. Closes scijava/scijava#176
Helper method to determine if a bound of another type is in fact recursive, with its own type parameter equal to the bounded type.
Previously we were recursively checking bounds of type variables even if those bounds were themselves recursive. This would create duplicate mappings that worked incidentally because the values were the same (since recursive) but this behavior broke in the change to recurse to raw types instead (avoiding infinite recursion errors)
d45c316 to
0040f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect and resolve mapping recursively parameterized types in GenericAssignability.inferTypeVariables
Closes scijava/scijava#176