Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Fix pluginInfo merging on Windows - #12

Merged
ctrueden merged 1 commit into
scijava/scijava-ops/clean-module-infofrom
scijava/scijava-ops/merge-plugins-ruby
Jun 24, 2020
Merged

ctrueden merged 1 commit into
scijava/scijava-ops/clean-module-infofrom
scijava/scijava-ops/merge-plugins-ruby

Conversation

@hinerm

@hinerm hinerm commented Jun 18, 2020

Copy link
Copy Markdown
Member

No description provided.

Bash scripts are less portable[1]. In this case the unionPluginInfo.sh
script failed to run on a 64-bit windows 10 Git Bash installation.

Using a dedicated Maven scripting plugin, instead of the Exec maven plugin,
works on Win10 and will hopefully give a better chance of working
cross-platform.

NB: we use ruby because on windows, project.basedir will have
backslashes that do not play well with the maven integration of other
languages (e.g. groovy).

[1] - https://stackoverflow.com/a/8433726
@gselzer

gselzer commented Jun 19, 2020 •

Copy link
Copy Markdown
Member

Nice work @hinerm! This works great! Builds from both a module level and from the incubator level (which I am sure you tested)!

My only consideration is about where the script should live. We do not want it to live in the incubator forever, so there are really two options:

  1. Put it in pom-scijava
  2. Put it in each project that needs it

I really don't know if I am familiar enough with pom-scijava to know if it belongs there. @ctrueden do you have opinions on this?

@ctrueden
ctrueden merged commit 7381996 into scijava/scijava-ops/clean-module-info Jun 24, 2020
@ctrueden

Copy link
Copy Markdown
Member

Thanks @hinerm. Let's keep it here in incubator for now. Over time, we'll converge on a longer-term solution that can hopefully become part of pom-scijava.

@ctrueden
ctrueden deleted the scijava/scijava-ops/merge-plugins-ruby branch June 24, 2020 18:25
Comment thread pom.xml Resolved
hinerm added a commit that referenced this pull request Jun 25, 2020
Putting the File.open statements in blocks ensures the files are closed
even if a problem occurs during processing.

See #12 (comment)

Thanks @imagejan!
@gselzer gselzer mentioned this pull request Jun 26, 2020
1 of 4 tasks
hinerm pushed a commit that referenced this pull request Jun 26, 2020
hinerm added a commit that referenced this pull request Jun 26, 2020
Putting the File.open statements in blocks ensures the files are closed
even if a problem occurs during processing.

See #12 (comment)

Thanks @imagejan!
hinerm added a commit that referenced this pull request Jun 14, 2021
Putting the File.open statements in blocks ensures the files are closed
even if a problem occurs during processing.

See #12 (comment)

Thanks @imagejan!
hinerm added a commit that referenced this pull request Jun 16, 2021
Putting the File.open statements in blocks ensures the files are closed
even if a problem occurs during processing.

See #12 (comment)

Thanks @imagejan!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants