This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Conversation
Bash scripts are less portable[1]. In this case the unionPluginInfo.sh script failed to run on a 64-bit windows 10 Git Bash installation. Using a dedicated Maven scripting plugin, instead of the Exec maven plugin, works on Win10 and will hopefully give a better chance of working cross-platform. NB: we use ruby because on windows, project.basedir will have backslashes that do not play well with the maven integration of other languages (e.g. groovy). [1] - https://stackoverflow.com/a/8433726
Member
|
Nice work @hinerm! This works great! Builds from both a module level and from the incubator level (which I am sure you tested)! My only consideration is about where the script should live. We do not want it to live in the incubator forever, so there are really two options:
I really don't know if I am familiar enough with pom-scijava to know if it belongs there. @ctrueden do you have opinions on this? |
Member
|
Thanks @hinerm. Let's keep it here in incubator for now. Over time, we'll converge on a longer-term solution that can hopefully become part of pom-scijava. |
imagejan
reviewed
Jun 25, 2020
hinerm
added a commit
that referenced
this pull request
Jun 25, 2020
Putting the File.open statements in blocks ensures the files are closed even if a problem occurs during processing. See #12 (comment) Thanks @imagejan!
hinerm
pushed a commit
that referenced
this pull request
Jun 26, 2020
…-ruby Fix pluginInfo merging on Windows
hinerm
added a commit
that referenced
this pull request
Jun 26, 2020
Putting the File.open statements in blocks ensures the files are closed even if a problem occurs during processing. See #12 (comment) Thanks @imagejan!
hinerm
added a commit
that referenced
this pull request
Jun 14, 2021
Putting the File.open statements in blocks ensures the files are closed even if a problem occurs during processing. See #12 (comment) Thanks @imagejan!
hinerm
added a commit
that referenced
this pull request
Jun 16, 2021
Putting the File.open statements in blocks ensures the files are closed even if a problem occurs during processing. See #12 (comment) Thanks @imagejan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.