Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

Make unionPluginInfo work on Windows - #11

Closed
hinerm wants to merge 1 commit into
scijava/scijava-ops/clean-module-infofrom
scijava/scijava-ops/merge-plugins-groovy
Closed

hinerm wants to merge 1 commit into
scijava/scijava-ops/clean-module-infofrom
scijava/scijava-ops/merge-plugins-groovy

Conversation

@hinerm

@hinerm hinerm commented Jun 17, 2020

Copy link
Copy Markdown
Member

No description provided.

Bash scripts are less portable[1]. In this case the unionPluginInfo.sh
script failed to run on a 64-bit windows 10 Git Bash installation.

Using a dedicated groovy Maven plugin, instead of the Exec maven plugin,
appears to work regardless of platform.

[1] - https://stackoverflow.com/a/8433726
@hinerm
hinerm requested review from ctrueden and gselzer June 17, 2020 18:53
@hinerm

hinerm commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

@ctrueden @gselzer I don't have any particular love for Groovy, it just has a dedicated execution plugin that works.

@gselzer

gselzer commented Jun 17, 2020

Copy link
Copy Markdown
Member

Hi @hinerm!

I checked out your branch and could not get scijava-ops to build when building from the incubator, since the paths to the META-INF files did not include scijava/scijava-ops. I think a nice solution would just be to use the absolute path to the META-INF files (via System.getProperty('user.dir')). This will only get you to the incubator level, though (unless you try to build from scijava/incubator/scijava/scijava-ops??). Unfortunately I do not have more time today to play with this.

@hinerm

hinerm commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

Thanks @gselzer ! Whoops yeah I was just building from the scijava/scijava-ops directory directly. I'll fix that.

@gselzer

gselzer commented Jun 17, 2020

Copy link
Copy Markdown
Member

It might be worth checking out GMavenPlus. This post suggests GMaven is no longer maintained, and GMavenPlus seems to have better support for passing command line args (which might be nice if we need this script in multiple projects).

I am naive on this, but do you know if having Groovy installed is necessary to run this script? Or does GMaven take care of that for you?

@hinerm

hinerm commented Jun 17, 2020

Copy link
Copy Markdown
Member Author

I am naive on this, but do you know if having Groovy installed is necessary to run this script? Or does GMaven take care of that for you?

That is a great question. You do not need to have Groovy installed. The plugin handles everything.

It might be worth checking out GMavenPlus.

Agreed, nice catch!

@hinerm

hinerm commented Jun 18, 2020

Copy link
Copy Markdown
Member Author

OK, groovy did NOT work out because for whatever reason, groovyshell explodes if you try to do anything with a string with backslashes pulled in from Maven.

Ruby seemed to be OK with it though, so new PR

@hinerm hinerm closed this Jun 18, 2020
@hinerm
hinerm deleted the scijava/scijava-ops/merge-plugins-groovy branch June 18, 2020 16:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants