This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Add type shortcut parsing to type value in @implNote annotations - #102
Merged
Merged
Conversation
hinerm
force-pushed
the
scijava/scijava-ops-engine/parse-type-shortcuts
branch
from
December 13, 2023 16:45
998f226 to
d4b2b36
Compare
hinerm
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows you to write the below class and call the internal Ops. Note that the absence of a
typeparameter inFunctionOps worked before - now, you can writetype=Computerortype=InplaceX(andtype=Function, if you really want) instead of typing out the whole op class name. The arity of those types will be pulled off of the method.For example, if you annotate a 5-parameter inplace Op with
type=Inplace3, the Op will become aInplaces.Arity5_3Closes scijava/scijava#163