MAINT: Remove any imports from __init__ (hide __version__)#38
Merged
seberg merged 1 commit intoscientific-python:mainfrom Oct 13, 2025
Merged
MAINT: Remove any imports from __init__ (hide __version__)#38seberg merged 1 commit intoscientific-python:mainfrom
__init__ (hide __version__)#38seberg merged 1 commit intoscientific-python:mainfrom
Conversation
The helpers were just not needed and should be private. `__version__` is a bit awkard and probably not quite right. Hiding it seems good to me, I also changed it to look-up via `__name__`. The thing is, I would like to vendor it, and then looking up `spatch` is wrong and can fail. Looking up `__name__` may not actually be any better, but for now I'll assume it is better than what we have. Not sure if this matters either way, if it does we might have to find a better solution...
Contributor
|
Thanks @seberg! Good judgement merging minor PRs like this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helpers were just not needed and should be private.
__version__is a bit awkard and probably not quite right. Hiding it seems good to me, I also changed it to look-up via__name__.The thing is, I would like to vendor it, and then looking up
spatchis wrong and can fail. Looking up__name__may not actually be any better, but for now I'll assume it is better than what we have.Not sure if this matters either way, if it does we might have to find a better solution...
Mini PR again that doesn't change any actual API. @eriknw, I'll just put this in I think since it is very small, but if this seems not great/ideal, I'll follow up!