WIP Fix navbar and footer alignments#699
Draft
agriyakhetarpal wants to merge 2 commits intoscientific-python:mainfrom
Draft
WIP Fix navbar and footer alignments#699agriyakhetarpal wants to merge 2 commits intoscientific-python:mainfrom
agriyakhetarpal wants to merge 2 commits intoscientific-python:mainfrom
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer needs a bit of work right now because it's not working well on downstream websites on narrower screens. The navbar is better aligned with the content now, and the logo and content are vertically aligned on pages where the secondary sidebar (for shortcuts) exists.
I am following how the PyData Sphinx Theme handles this here – its navbar and footer are wider, though the mixture of the theme styles and ours makes it much harder to fix ours. I'd wish we changed that somehow.
Closes #698
Closes #688