Add support for grid gutters to control spacing between grid items#693
Open
agriyakhetarpal wants to merge 8 commits intoscientific-python:mainfrom
Open
Add support for grid gutters to control spacing between grid items#693agriyakhetarpal wants to merge 8 commits intoscientific-python:mainfrom
agriyakhetarpal wants to merge 8 commits intoscientific-python:mainfrom
Conversation
❌ Deploy Preview for scientific-python-hugo-theme failed.Built without sensitive environment variables
|
Member
Author
|
The deployment failure is just the link checker plugin. This has been ready for review; sites are building fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #596. This was already supported in our sphinx-design CSS, just that we didn't expose it as a parameter in the
gridshortcode, so it was partially implemented (no pun intended :P).The spacing scale formula is defined here:
scientific-python-hugo-theme/assets/theme-css/sphinx-design/_spacing.scss
Lines 1 to 9 in b3056c3
which generates the responsive
sd-g-*classes that control the--sd-gutter-xand--sd-gutter-yvariables.The gutter parameter can either take one or four integers between 0 to 5. The default is 2 for backwards compatibility. The four integers in the value, if set, correspond to the
xs/sm/md/lgbreakpoints. See the Bootstrap docs for more, which is what sphinx-design relies on: https://getbootstrap.com/docs/5.2/layout/grid/#grid-options