fix: corrige dados de coleções (VEN, RVE, RVO) e atualiza tipos de documentos citáveis #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Este PR atualiza dependências e ajusta a lista de tipos de documento citáveis para contemplar novos formatos (ex.: data-article).
Changes:
- Atualiza
xylosepara1.35.13emrequirements.txt. - Inclui
data-articleemCITABLE_DOCUMENT_TYPESpara que o tipo seja tratado como “citável”.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| requirements.txt | Bump de versão do xylose para endereçar issues mencionadas. |
| choices.py | Amplia a lista de tipos de documentos citáveis, impactando flags/contagens de “citable docs”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ]) | ||
|
|
||
| CITABLE_DOCUMENT_TYPES = ( | ||
| 'data-article', |
There was a problem hiding this comment.
CITABLE_DOCUMENT_TYPES uses u'...' literals throughout (Python 2.7 compatibility is declared in setup.py). Adding 'data-article' as a byte string introduces a mixed str/unicode tuple; make it a unicode literal for consistency and to avoid subtle coercion issues in Py2 code paths.
Suggested change
| 'data-article', | |
| u'data-article', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Descrição
Este PR agrupa correções estruturais nas coleções Venezuela (VEN), Revista Eletrônica (RVE) e Revista de Odontologia (RVO), além de atualizar as definições de documentos citáveis e dependências do projeto.
🛠️ Alterações Principais
1.35.13para endereçar as issues Atualizar URL da coleção SciELO Venezuela no KBART #67 e Arquivo KBART em tabs_rve.zip (RevEnf) contém links incorretos que apontam para a coleção RevOdonto #75.data-articlena listaCITABLE_DOCUMENT_TYPES, garantindo que novos formatos de publicação sejam processados corretamente pelas métricas.ven,rveervo(conforme o histórico do branch).📝 Notas de Versão (Changelog)
xyloseto1.35.13.data-article.✅ Checklist para o Revisor
data-articleimpacta o cálculo de impacto de coleções específicas?