fix: update launch script handling for mingw-w64/msys2 on Windows #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
wszqkzqk
added a commit
to wszqkzqk/MINGW-packages
that referenced
this pull request
Dec 10, 2025
* Backport schrodinger/pymol-open-source#487 * Prevent hardcoded paths in pymol.bat launcher Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
wszqkzqk
added a commit
to wszqkzqk/MINGW-packages
that referenced
this pull request
Dec 10, 2025
* Backport schrodinger/pymol-open-source#487 * Prevent hardcoded paths in pymol.bat launcher Signed-off-by: Zhou Qiankang <wszqkzqk@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
pymol.batlauncher generation on Windows attempts to write relative paths topython.exeand the PyMOL module. However, when the build directory differs from the installation directory (e.g., during package repackaging for MSYS2/mingw-w64), this results in incorrect, hardcoded absolute paths that break the launcher:This PR fixes the issue specifically for the mingw-w64/msys2 building and packaging by simplifying the launcher logic. Instead of computing fragile relative paths, it now uses the reliable invocation, which ensures the launcher always uses the Python interpreter adjacent to the batch file:
With the protection of if clause, it will not affect non-mingw/msys2 behavior.
Tested on my own machine.