Skip to content

Conversation

@pslacerda1
Copy link
Contributor

No description provided.

@pslacerda1
Copy link
Contributor Author

I started a wiki page for new_command and think that everything is ok by now.

Can you point me on how to make the community aware so they can also test?

@pslacerda1 pslacerda1 changed the title Some new command fixes Some new_command fixes Nov 29, 2025
@pslacerda1
Copy link
Contributor Author

May I add these entries from my .gitignore into yours?

*.egg-info/
*.so
.venv/

@JarrettSJohnson
Copy link
Member

Hi Pedro, couple of high-level things first:

  1. For your PRs, can you make a description of a summary/what the PR is trying to accomplish?
  2. Can I ask why you're removing helping.py in tests?
  3. Changes to the .gitignore would be better suited as a separate PR.

@pslacerda1
Copy link
Contributor Author

  1. I added support to the quiet=1 option from PyMOL CLI. Also better error messages explaining the reason of the calling error (in case the user made a calling error). Initially I tried to make multi-line error messages (like Tornado exceptions if I recall correctly), but they were becoming ugly and not user-friendly, so I gave up.
  2. I removed tests/helping.py by mistake!

And I don't know why the tests are failing, in my machine they're ok.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants