Fix error on typed lists

pslacerda1 · pslacerda1 · commit ddb5be6f835f · 2025-11-29T17:42:32.000-03:00
diff --git a/modules/pymol/commanding.py b/modules/pymol/commanding.py
@@ -641,11 +641,13 @@ def _into_types(type, value):
                     
             elif issubclass(list, origin):
                 args = get_args(type)
-                if len(args) > 0:
+                if len(args) == 1:
                     f = args[0]
-                else:
-                    f = lambda x: x
-                return [f(i) for i in shlex.split(value)]
+                    return [
+                        _into_types(f, a)
+                        for a in shlex.split(value)
+                    ]
+                return shlex.split(value)
         
         elif issubclass(type, Enum):
             if value in type:
diff --git a/testing/tests/api/test_commanding.py b/testing/tests/api/test_commanding.py
@@ -1,9 +1,8 @@
-from pytest import mark
-from pymol import cmd
 import sys
+from pytest import mark
 from typing import List, Union, Any, Tuple
 from pathlib import Path
-
+from pymol import cmd
 
 def test_docstring():
     @cmd.new_command
@@ -40,6 +39,7 @@ def func(
     out, err = capsys.readouterr()
     assert out + err == ''
 
+
 def test_path(capsys):
     @cmd.new_command
     def func(dirname: Path = Path('.')):
@@ -50,7 +50,6 @@ def func(dirname: Path = Path('.')):
     assert out + err == ''
 
 
-
 @mark.skip("This function does not works as expected")
 def test_any(capsys):
     @cmd.new_command
@@ -61,29 +60,36 @@ def func(old_style: Any):
     out, err = capsys.readouterr()
     assert 'AssertionError' not in out+err
 
+
 def test_list(capsys):
     @cmd.new_command
     def func(a: List):
         assert a[1] == "2"
-
     cmd.do("func 1 2 3")
     out, err = capsys.readouterr()
     assert out + err == ''
 
     @cmd.new_command
     def func(a: List[int]):
         assert a[1] == 2
-
     cmd.do("func 1 2 3")
     out, err = capsys.readouterr()
     assert out + err == ''
 
+    @cmd.new_command
+    def func(a: List[bool]):
+        assert a.pop(0) == False
+        assert a.pop(0) == True
+    cmd.do("func 0 yes")
+    out, err = capsys.readouterr()
+    assert out + err == ''
+
+
 def test_tuple(capsys):
     @cmd.new_command
     def func(a: Tuple[str, int]):
-        assert a == ("fooo", 42)
-
-    cmd.do("func fooo 42")
+        assert a == ("fooo a", 42)
+    cmd.do("func 'fooo a' 42")
     out, err = capsys.readouterr()
     assert out + err == ''
 
@@ -97,6 +103,7 @@ def func(a: str="sele"):
     out, err = capsys.readouterr()
     assert out + err == ''
 
+
 @mark.skipif(
     sys.version_info < (3, 11),
     reason="Requires StrEnum of Python 3.11+"
@@ -113,6 +120,7 @@ def func(e: E):
     out, err = capsys.readouterr()
     assert out + err == ''
 
+
 def test_quiet(capsys):
     @cmd.new_command
     def func(quiet: bool=True):
