fix: support disabling HTTPS verification - #1066
Closed
ketankurhade wants to merge 1 commit into
Closed
ketankurhade wants to merge 1 commit into
ketankurhade wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes HTTPS verification handling when
verify: falseis explicitly configured.The request-level
verifyoption was already parsed by ScanAPI but was not forwarded to the underlyinghttpx.HTTPTransport, causing certificate verification to remain enabled.The fix forwards the
verifyvalue toHTTPTransportwhile preserving secure verification by default.Related Issue
Fixes #1018
Testing
Two existing Windows-specific path assertion failures are unrelated to this change.