fix: correct dynamic URL rendering - #1065
Closed
ketankurhade wants to merge 6 commits into
Closed
ketankurhade wants to merge 6 commits into
ketankurhade wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes dynamic URL rendering when literal text is adjacent to environment or custom variables.
The variable interpolation regex was incorrectly consuming literal characters surrounding
${...}expressions. The regex was updated to match only the variable expression itself.Regression tests were added for literal prefixes, suffixes, and complete URL path rendering.
Related Issue
Fixes #1007
Testing
Two existing Windows-specific path assertion failures are unrelated to this change.